Skip to content

DO NOT SIMPLY MERGE READ DESCRIPTION - InstallUtil doesn't work with net core executables? #12232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdmiralSnyder wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DO NOT SIMPLY MERGE READ DESCRIPTION - InstallUtil doesn't work with net core executables? #12232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion xml/System.ServiceProcess/ServiceBase.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,9 @@

You do not have to implement <xref:System.ServiceProcess.ServiceBase.OnStart%2A>, <xref:System.ServiceProcess.ServiceBase.OnStop%2A>, or any other method in <xref:System.ServiceProcess.ServiceBase>. However, the service's behavior is described in <xref:System.ServiceProcess.ServiceBase.OnStart%2A>, so at minimum, this member should be overridden. The `main()` function of the executable registers the service in the executable with the Service Control Manager by calling the <xref:System.ServiceProcess.ServiceBase.Run%2A> method. The <xref:System.ServiceProcess.ServiceBase.ServiceName%2A> property of the <xref:System.ServiceProcess.ServiceBase> object passed to the <xref:System.ServiceProcess.ServiceBase.Run%2A> method must match the <xref:System.ServiceProcess.ServiceInstaller.ServiceName%2A> property of the service installer for that service.

You can use `InstallUtil.exe` to install services on your system.
You can use `sc create` to install services on your system.
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence lacks completeness for a documentation change. It should provide more context about when to use sc create versus InstallUtil.exe, particularly noting that InstallUtil.exe only works with .NET Framework applications, while sc create works with both .NET Framework and modern .NET (Core, .NET 5+). The sentence should end with a period per coding guidelines.

Copilot generated this review using guidance from repository custom instructions.
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is incomplete as it doesn't address the many other references to InstallUtil.exe throughout the System.ServiceProcess namespace documentation. Files like ServiceProcessInstaller.xml, ServiceInstaller.xml, and ns-System.ServiceProcess.xml still reference InstallUtil.exe. A comprehensive update should either maintain guidance for both tools (with appropriate notes about .NET Framework vs. modern .NET compatibility) or update all related documentation consistently.

Suggested change
You can use `sc create` to install services on your system.
You can use the `sc create` command to install services that target modern .NET, or use `InstallUtil.exe` to install services that target the .NET Framework.

Copilot uses AI. Check for mistakes.



Comment on lines +78 to 79
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line contains only whitespace and should be removed. Empty lines in XML documentation should not contain trailing spaces.

Suggested change

Copilot uses AI. Check for mistakes.
> [!NOTE]
> You can specify a log other than the Application event log to receive notification of service calls, but neither the <xref:System.ServiceProcess.ServiceBase.AutoLog%2A> nor the <xref:System.ServiceProcess.ServiceBase.EventLog%2A> property can write to a custom log. Set <xref:System.ServiceProcess.ServiceBase.AutoLog%2A> to `false` if you do not want to use automatic logging.
Expand Down
Loading