Skip to content

[nightly] Update common Docker engineering infrastructure with latest #7204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dotnet-docker-bot wants to merge 1 commit into
base: nightly
Choose a base branch
from
+8 −2
Open

[nightly] Update common Docker engineering infrastructure with latest #7204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions eng/docker-tools/DEV-GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,8 @@ When you queue a new run, you can override these as runtime parameters:

This avoids the multi-hour rebuild cycle when you just need to retry a failed operation.

When signing is enabled, use `"publish"` by itself only if the images from `sourceBuildPipelineRunId` were already signed and the current run is not building new images. Use `"sign,publish"` when the current run still needs to sign them before publishing.

---

## Troubleshooting
Expand Down
6 changes: 5 additions & 1 deletion eng/docker-tools/templates/stages/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ stages:
# Run when all of the following are true:
# 1. The pipeline has not been canceled.
# 2. The stages variable includes 'publish'.
# 3. Either signing is not enabled, or the Sign stage succeeded.
# 3. Either signing is not enabled, this run is reusing previously signed images, or the Sign stage succeeded.
# 4. Either the stages variable does not include 'build', or Post_Build succeeded.
# 5. Either the stages variable does not include 'test', or Test succeeded/was skipped.
condition: "
Expand All @@ -56,6 +56,10 @@ stages:
contains(variables['stages'], 'publish'),
or(
ne(lower('${{ parameters.publishConfig.Signing.Enabled }}'), 'true'),
and(
not(contains(variables['stages'], 'build')),
not(contains(variables['stages'], 'sign'))
),
in(dependencies.Sign.result, 'Succeeded', 'SucceededWithIssues')
),
or(
Expand Down
2 changes: 1 addition & 1 deletion eng/docker-tools/templates/variables/docker-images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
variables:
imageNames.imageBuilderName: mcr.microsoft.com/dotnet-buildtools/image-builder:2972986
imageNames.imageBuilderName: mcr.microsoft.com/dotnet-buildtools/image-builder:2980918
imageNames.imageBuilder: $(imageNames.imageBuilderName)
imageNames.imageBuilder.withrepo: imagebuilder-withrepo:$(Build.BuildId)-$(System.JobId)
imageNames.testRunner: mcr.microsoft.com/dotnet-buildtools/prereqs:azurelinux3.0-docker-testrunner
Expand Down
Loading