Parser: recover on unfinished if and binary expressions#19724
Open
auduchinok wants to merge 6 commits into
Open
Parser: recover on unfinished if and binary expressions#19724auduchinok wants to merge 6 commits into
auduchinok wants to merge 6 commits into
Conversation
Contributor
❗ Release notes required
|
github-actions
Bot
added
the
⚠️ Affects-Bootstrap
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
auduchinok
force-pushed
the
parser-if-binary
branch
from
c31c0dc to
5730e13
Compare
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@T-Gro Can we somehow reduce the amount of generated comments, maybe? Could just setting labels be sufficient? |
Member
|
@auduchinok : Yes, will try to reduce the text to a minimum and maybe move from "resolve old + write new" to "update existing comment" |
This comment has been minimized.
This comment has been minimized.
Contributor
|
🔍 Tooling Safety Check — Affects-Bootstrap (scanned-sha)729cfe4852e2592bd537aa19675970da0eb2c2b0(/scanned-sha)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An alternative take on #17257.
This PR continues the approach from #19708 and applies it to additional rules. Unlike that PR, the new precedence used in a rule that has much more productions, which sometimes is a bit riskier, but, together with the lowest precedence possible, it gives good recovery in cases that previously didn't work and hopefully won't interfere with other rules.