Skip to content

Parser: fix unexpected diagnostics in debug builds, improve error messages#19730

Merged
T-Gro merged 3 commits into
dotnet:mainfrom
auduchinok:parser-diagnostics-accessors
May 14, 2026
Merged

Parser: fix unexpected diagnostics in debug builds, improve error messages#19730
T-Gro merged 3 commits into
dotnet:mainfrom
auduchinok:parser-diagnostics-accessors

Conversation

@auduchinok
Copy link
Copy Markdown
Member

@auduchinok auduchinok commented May 13, 2026

Fixes parser diagnostics in property tests in debug builds. It also improves the error messages.

The diagnostics were added in syntax tree tests for properties, making it more difficult to work on the parser:

(6,0)-(6,1) parse error Incomplete structured construct at or before this point. (no 'in' context found: [[NONTERM_classMemberSpfnGetSetElements];
 [NONTERM_classMemberSpfnGetSetElements; NONTERM_classMemberSpfnGetSetElements];
 [NONTERM_classMemberSpfnGetSetElements; NONTERM_classMemberSpfnGetSetElements;
  NONTERM_classMemberSpfnGetSetElements];
 [NONTERM_classMemberSpfnGetSetElements; NONTERM_classMemberSpfnGetSetElements;
  NONTERM_classMemberSpfnGetSetElements];
 [NONTERM_classMemberSpfnGetSet; NONTERM_classMemberSpfnGetSet];
 [NONTERM_autoPropsDefnDecl]; [NONTERM_autoPropsDefnDecl];
 [NONTERM_autoPropsDefnDecl; NONTERM_autoPropsDefnDecl;
  NONTERM_autoPropsDefnDecl];
 [NONTERM_autoPropsDefnDecl; NONTERM_autoPropsDefnDecl;
  NONTERM_autoPropsDefnDecl];
 [NONTERM_autoPropsDefnDecl; NONTERM_autoPropsDefnDecl;
  NONTERM_autoPropsDefnDecl; NONTERM_autoPropsDefnDecl];
 [NONTERM_autoPropsDefnDecl; NONTERM_autoPropsDefnDecl;
  NONTERM_autoPropsDefnDecl; NONTERM_autoPropsDefnDecl];
 [NONTERM_autoPropsDefnDecl; NONTERM_autoPropsDefnDecl;
  NONTERM_autoPropsDefnDecl; NONTERM_autoPropsDefnDecl]]). Expected identifier, '(', '(*)' or other token.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/11.0.100.md

@github-actions github-actions Bot added the AI-Tooling-Check-Scanned-Clean Tooling check: diff analyzed, no interesting infrastructure files label May 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Tooling Safety Check — Clean

(scanned-sha)1ad14e36c25f110b38a5685e83d3e09a9bafdf0f(/scanned-sha)

Generated by PR Tooling Safety Check · ● 5.3M ·

@auduchinok
Copy link
Copy Markdown
Member Author

This is ready.

@github-project-automation github-project-automation Bot moved this from New to In Progress in F# Compiler and Tooling May 14, 2026
@T-Gro T-Gro enabled auto-merge (squash) May 14, 2026 10:09
@T-Gro T-Gro merged commit 242c396 into dotnet:main May 14, 2026
50 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in F# Compiler and Tooling May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Tooling-Check-Scanned-Clean Tooling check: diff analyzed, no interesting infrastructure files

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants