Update wasm mainjs path#5123
Draft
LoopedBard3 wants to merge 8 commits intodotnet:update-wasm-mainjs-pathfrom
Draft
Update wasm mainjs path#5123LoopedBard3 wants to merge 8 commits intodotnet:update-wasm-mainjs-pathfrom
LoopedBard3 wants to merge 8 commits intodotnet:update-wasm-mainjs-pathfrom
Conversation
Pass --wasm-coreclr to benchmarks_ci.py when codeGenType is 'wasm' (non-AOT) so that BDN uses the CoreCLR runtime pack instead of Mono for WASM benchmarks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The BDN 0.16.0-custom analyzer targets Roslyn 5.0.0.0, which is newer than the Roslyn shipped with .NET 9.0 SDK (4.12.0.0). Since TreatWarningsAsErrors is enabled, this breaks net9.0 builds. The analyzer simply won't load on older SDKs, which is benign. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
BDN now provides its own test-main.js, so the payload build no longer needs to copy it from the runtime repo. This fixes the build failure when the file doesn't exist at src/mono/browser/test-main.js. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use UseMonoRuntime property to conditionally resolve the runtime pack: - Mono (default): Microsoft.NETCore.App.Runtime.Mono.browser-wasm - CoreCLR (UseMonoRuntime=false): Microsoft.NETCore.App.Runtime.browser-wasm This prepares MicroBenchmarks.csproj for CoreCLR WASM support. BDN's auto-generated project resolves packs via RestoreAdditionalProjectSources pointing to built-nugets, so it needs the CoreCLR pack to be produced by the runtime build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The BrowserWasm build artifact includes the CoreCLR runtime pack at staging/microsoft.netcore.app.runtime.browser-wasm/Release/ but it was never installed into the dotnet SDK's packs directory. Install it at packs/Microsoft.NETCore.App.Runtime.browser-wasm/<version>/ so the SDK can resolve it when --wasm-coreclr is used (non-Mono WASM builds). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR just to make viewing my changes before successful testing more easily viewed.