Fix ProgressBar dark mode rendering inconsistency across style variants#14551
Open
LeafShi1 wants to merge 1 commit into
Open
Fix ProgressBar dark mode rendering inconsistency across style variants#14551LeafShi1 wants to merge 1 commit into
LeafShi1 wants to merge 1 commit into
Conversation
SimonZhao888
approved these changes
May 22, 2026
Member
|
Looks good to me! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates WinForms ProgressBar dark-mode behavior to avoid Windows 11 (25H2+) style-dependent themed rendering differences by disabling native theming in the affected cases and explicitly driving bar/background colors via PBM color messages, reapplying this on handle recreation and relevant system/user changes.
Changes:
- Centralizes dark-mode/custom-color handling in
ApplyTheming()and calls it from handle creation, style changes, color changes, and user preference updates. - Introduces “effective” back/fore color helpers to ensure consistent default colors (including a dark-mode default background).
- Removes the prior
OnCreateControl-time dark-mode workaround in favor of handle-based reapplication.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // across Blocks/Continuous/Marquee. Disable visual styles and drive colors via PBM_SET*COLOR | ||
| // for consistent appearance. | ||
| PInvoke.SetWindowTheme(HWND, " ", " "); | ||
| } |
Comment on lines
+117
to
+118
| // Re-apply theming after handle recreation | ||
| ApplyTheming(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14546
Root Cause
The native themed ProgressBar rendering on newer Windows builds applies style-dependent visual effects in dark mode. As a result,
Blocks,Continuous, andMarqueedo not share a single consistent rendering path. When the control depends on native theming, the background and foreground colors can diverge across styles.Proposed changes
ProgressBarcolors through explicit color messages.SystemColors.ControlTextas the dark-mode background color to satisfy contrast requirements.Customer Impact
Regression?
Risk
Screenshots
Before
Blocks,Continuous, andMarqueerender with different visual results.Recording.2026-05-20.095837.mp4
After
Three ProgressBar styles (
Blocks,Continuous,Marquee) render with consistent colors in dark mode and color changes and style switching work correctlyAfterChanges.mp4
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow