Skip to content

SelectTree有ShowSearch参数,漏掉OnSearchAsync参数补齐#7844

Open
Tony-ST0754 wants to merge 1 commit intomainfrom
SelectTree_AddParameter_OnSearchAsync
Open

SelectTree有ShowSearch参数,漏掉OnSearchAsync参数补齐#7844
Tony-ST0754 wants to merge 1 commit intomainfrom
SelectTree_AddParameter_OnSearchAsync

Conversation

@Tony-ST0754
Copy link
Copy Markdown
Collaborator

@Tony-ST0754 Tony-ST0754 commented Apr 7, 2026

SelectTree有ShowSearch参数,漏掉OnSearchAsync参数

Link issues

fixes #7843

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add asynchronous search callback support to SelectTree when search is enabled.

New Features:

  • Expose an OnSearchAsync callback parameter on SelectTree to handle asynchronous search operations when ShowSearch is enabled.

Enhancements:

  • Wire the SelectTree OnSearchAsync parameter through to the internal TreeView component to enable custom search behavior.

SelectTree有ShowSearch参数,漏掉OnSearchAsync参数
@bb-auto
Copy link
Copy Markdown

bb-auto bot commented Apr 7, 2026

Thanks for your PR, @Tony-ST0754. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@bb-auto bb-auto bot requested a review from ArgoZhang April 7, 2026 02:11
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Apr 7, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds an async search callback parameter to SelectTree and wires it through to the underlying TreeView when search is enabled.

Sequence diagram for SelectTree search with OnSearchAsync

sequenceDiagram
    actor User
    participant SelectTree_TValue_ as SelectTree~TValue~
    participant TreeView_TValue_ as TreeView~TValue~
    participant OnSearchAsyncHandler as OnSearchAsync_handler

    User->>SelectTree_TValue_: type_search_text(query)
    SelectTree_TValue_->>TreeView_TValue_: render_with(ShowSearch=true, OnSearchAsync)
    User->>TreeView_TValue_: input_search_text(query)
    TreeView_TValue_->>OnSearchAsyncHandler: OnSearchAsync(query)
    OnSearchAsyncHandler-->>TreeView_TValue_: List<TreeViewItem<TValue>> results
    TreeView_TValue_->>User: display_filtered_tree(results)
Loading

Class diagram for updated SelectTree OnSearchAsync parameter

classDiagram
    class SelectTree~TValue~ {
        +bool ShowSearch
        +Func~string?, Task~List~TreeViewItem~TValue~~?~~~ OnSearchAsync
    }

    class TreeView~TValue~ {
        +IEnumerable~TreeViewItem~TValue~~ Items
        +bool ShowIcon
        +bool ShowSearch
        +bool ShowResetSearchButton
        +bool CanExpandWhenDisabled
        +string CustomKeyAttribute
        +Func~string?, Task~List~TreeViewItem~TValue~~?~~~ OnSearchAsync
        +Task OnTreeItemClick(TValue value)
        +Task OnExpandNodeAsync(TreeViewItem~TValue~ node)
    }

    class TreeViewItem~TValue~ {
        +TValue Value
        +string Text
        +bool IsExpanded
        +bool IsDisabled
    }

    SelectTree~TValue~ --> TreeView~TValue~ : passes_OnSearchAsync
    TreeView~TValue~ --> TreeViewItem~TValue~ : uses
Loading

File-Level Changes

Change Details Files
Expose async search callback on SelectTree and forward it to TreeView when ShowSearch is enabled.
  • Add OnSearchAsync component parameter with XML documentation to SelectTree backing class.
  • Wire OnSearchAsync through from SelectTree to the nested TreeView component in the .razor markup so searches are handled by the provided callback.
  • Add missing using directive for System.Timers, potentially required by related functionality.
src/BootstrapBlazor/Components/Select/SelectTree.razor.cs
src/BootstrapBlazor/Components/Select/SelectTree.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#7843 Expose an OnSearchAsync parameter on the SelectTree component so that consumers can provide a search callback.
#7843 Connect the SelectTree.OnSearchAsync parameter to the underlying TreeView so that when ShowSearch is true, the search functionality can be fully executed via the callback.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Apr 7, 2026
@bb-auto bb-auto bot added this to the v10.5.0 milestone Apr 7, 2026
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The newly added using System.Timers; in SelectTree.razor.cs is not used anywhere in this file and should be removed to avoid unnecessary dependencies.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The newly added `using System.Timers;` in `SelectTree.razor.cs` is not used anywhere in this file and should be removed to avoid unnecessary dependencies.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (bcf0717) to head (12b94ee).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7844   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          764       764           
  Lines        34165     34166    +1     
  Branches      4704      4704           
=========================================
+ Hits         34165     34166    +1     
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(SelectTree): SelectTree有ShowSearch参数,漏掉OnSearchAsync参数

2 participants