Open
Conversation
This commit introduces support for logging shell commands in Zsh alongside the existing Bash support. Key changes: - Modified `recent2.py` to handle different shell types (`bash`, `zsh`) via a `--shell` argument to `log-recent`. - The `log-recent` command now accepts `--raw_command_text` and `--sequence_num` for direct input, primarily for Zsh integration. - Updated `check_prompt` to be shell-aware and provide appropriate guidance. - Created `recent2_zsh_setup.sh` containing Zsh `precmd` and `preexec` hook functions to capture command details and call `log-recent`. - Updated `README.md` with detailed instructions for Zsh users, including the necessary `.zshrc` snippet. Zsh integration uses `HISTCMD` for the sequence number and captures the full command text from the `preexec` hook arguments.
This commit refines the Zsh integration for recent2 based on user feedback. Key changes: - Simplified `check_prompt()` in `recent2.py` to only perform active checks (i.e., for `PROMPT_COMMAND`) when running in a Bash shell. This makes the experience smoother for Zsh users. - Cleaned up `recent2_zsh_setup.sh` by removing excessive comments and ensuring the functional code is directly sourceable for easier integration into `.zshrc`. - The `log()` function in `recent2.py` retains the necessary arguments (`--shell`, `--raw_command_text`, `--sequence_num`) for Zsh to pass command data directly. - `README.md` instructions for Zsh remain accurate, guiding users to either copy the snippet or source the setup file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces support for logging shell commands in Zsh alongside the existing Bash support.
Key changes:
recent2.pyto handle different shell types (bash,zsh) via a--shellargument tolog-recent.log-recentcommand now accepts--raw_command_textand--sequence_numfor direct input, primarily for Zsh integration.check_promptto be shell-aware and provide appropriate guidance.recent2_zsh_setup.shcontaining Zshprecmdandpreexechook functions to capture command details and calllog-recent.README.mdwith detailed instructions for Zsh users, including the necessary.zshrcsnippet.Zsh integration uses
HISTCMDfor the sequence number and captures the full command text from thepreexechook arguments.