Skip to content

chore(design-system): add vitest artifacts to gitignore [AR-48187] #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iromanchuk-dn wants to merge 3 commits into from
Closed

chore(design-system): add vitest artifacts to gitignore [AR-48187] #334

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c36cb35
chore(design-system): add vitest artifacts to gitignore [AR-48187]
iromanchuk-dn Mar 30, 2026
cbf16a7
add newline
iromanchuk-dn Mar 30, 2026
ba2b5f8
Merge branch 'main' into update-gitignore
iromanchuk-dn Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/design-system/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
.scss-dts
storybook-static
__screenshots__
.vitest-attachments
Comment on lines +3 to +4
Copy link
Copy Markdown
Member

@StyleShit StyleShit Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__screenshots__ shouldn't be ignored, we'll want to commit them at some point
Why do you need to ignore it? Are there any screenshots created locally?

Copy link
Copy Markdown
Collaborator Author

@iromanchuk-dn iromanchuk-dn Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any screenshots created locally?- exactly. Quite often Cursor agent executes tests and it generates screenshots.

Copy link
Copy Markdown
Member

@StyleShit StyleShit Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but why? do we have any toMatchScreenshot tests?

Copy link
Copy Markdown
Collaborator Author

@iromanchuk-dn iromanchuk-dn Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think AI does it to view the screenshot of failed test and understand what's wrong

Copy link
Copy Markdown
Member

@StyleShit StyleShit Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm
but then what will happen when we'll want to use screenshots ourselves? This ignore will block us, no?

Copy link
Copy Markdown
Collaborator Author

@iromanchuk-dn iromanchuk-dn Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably it will, I will cancel this PR.

Loading