feat(design-system): change DsDrawer responsive strategy [AR-53856]#358
Closed
vpolessky-dn wants to merge 1 commit intodrivenets:nextfrom
Closed
feat(design-system): change DsDrawer responsive strategy [AR-53856]#358vpolessky-dn wants to merge 1 commit intodrivenets:nextfrom
vpolessky-dn wants to merge 1 commit intodrivenets:nextfrom
Conversation
…nsive styling [AR-53842] (drivenets#338) feat(design-system): change DsDrawer responsive strategy [AR-53856] Made-with: Cursor
vpolessky-dn
requested review from
StyleShit,
aroba-dn,
iromanchuk-dn and
mmurawski-dn
vpolessky-dn
changed the title
vpolessky-dn
changed the title
StyleShit
reviewed
Apr 12, 2026
| width: var(--col-span-#{$i}); | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Why are you removing this? It should be the same as per what I'm seeing in Figma
Am I missing something?
Member
There was a problem hiding this comment.
- This PR is built on top of something else? Why are all the changes in non-drawer code?
- This button should be removed in
next. I don't think we should bother with it 🤷
Member
There was a problem hiding this comment.
what are these changesets names? it should be auto-generated by pnpm run changelog, not written manually
Collaborator
Author
|
@StyleShit moving changes to another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.