Conversation
hamishwillee
left a comment
hamishwillee
left a comment
There was a problem hiding this comment.
This looks correct to me, as mission_item is deprecated. @peterbarker Do you know how the CI works - not reporting anything on this.
…ere was no heartbeat for 30 seconds.
…ere was no heartbeat for 30 seconds.
|
@morzack What do you think about this one? |
hamishwillee
requested review from
morzack and
peterbarker
and removed request for
hamishwillee
|
@ShafiqSadat I'm not going to merge this. That has to be done by someone with more technical knowledge. I have requested Peter and John, but this will have to await their attention. |
peterbarker
left a comment
peterbarker
left a comment
There was a problem hiding this comment.
I've been wanting to do something like this twine thing for a very long time :-)
There are good changes in here, but you've got several unrelated changes mixed into the one PR, making merging anything difficult.
You should also only have a single commit per logical change, and commit messages which actually say what logical change has been made.
| def _update_channel(self, channel, value): | ||
| # If we have channels on different ports, we expand the Channels | ||
| # object to support them. | ||
| channel = int(channel) |
There was a problem hiding this comment.
This change is strange
dronekit/mavlink.py
Outdated
| except APIException as e: | ||
| self._logger.exception('Exception in MAVLink input loop') | ||
| #self._logger.exception('Exception in MAVLink input loop') | ||
| self._logger.warning('%s' % str(e)) |
| self.notify_attribute_listeners('home_location', self.home_location, cache=True) | ||
|
|
||
| @self.on_message(['WAYPOINT', 'MISSION_ITEM']) | ||
| @self.on_message(['WAYPOINT', 'MISSION_ITEM', 'MISSION_ITEM_INT']) |
There was a problem hiding this comment.
There is a bug if It is a mission item int then you should divide to 1e7
| self._master.mav.mission_item_send(0, 0, 0, frame, | ||
| self._master.mav.mission_item_int_send(0, 0, 0, frame, | ||
| mavutil.mavlink.MAV_CMD_NAV_WAYPOINT, 2, 0, 0, | ||
| 0, 0, 0, location.lat, location.lon, |
There was a problem hiding this comment.
conversion issu int(location.lat * 1e7), int(location.lon * 1e7)
4 participants
Fixes #1208