Fix inaccessible menu links returned by data producers #1204#1237
Closed
sunerphey wants to merge 1 commit intodrupal-graphql:8.x-4.xfrom
Closed
Fix inaccessible menu links returned by data producers #1204#1237sunerphey wants to merge 1 commit intodrupal-graphql:8.x-4.xfrom
sunerphey wants to merge 1 commit intodrupal-graphql:8.x-4.xfrom
Conversation
Contributor
|
Thanks, I think that makes a lot of sense! Can you check the existing test coverage and expand it to cover this? |
Contributor
|
the MenuLinks data producer was fixed in https://www.drupal.org/project/graphql/issues/3476389 Not sure we need to fix the subtree dataproducer as well, please open a new drupal.org issue and merge request if needed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1204 by updating pull request #1205