This repository was archived by the owner on Jan 5, 2018. It is now read-only.
Fix removed redirects#203
Open
podarok wants to merge 2 commits intodrupal-media:8.x-1.xfrom
podarok:patch-2
Open
Fix removed redirects#203podarok wants to merge 2 commits intodrupal-media:8.x-1.xfrom podarok:patch-2
podarok wants to merge 2 commits intodrupal-media:8.x-1.xfrom
podarok:patch-2
Conversation
If module been used for embeding forms, redirect exception can't be executed. This patch is a fix for that
Member
There was a problem hiding this comment.
Would this look nicer if we'd add another catch() block?
Author
|
@slashrsm done |
Member
|
Looks good now. Thanks! Could you create an issue in https://www.drupal.org/project/issues/entity_embed, rebase and squash the two commits and reword commit message to reference issue # and contributors (yourself:)). |
Member
|
Can you help explain this more? I don't really understand. An issue in the module issue queue would help. |
Author
|
@davereid When you are inserting entity form with redirect via entity_embed - redirect created by throwing redirect Exception. I'm talking about inserting Contact form(core module) via entity_embed. |
Author
Member
|
You don't need maintainer-ship to create an issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If module been used for embeding forms, redirect exception can't be executed.
This patch is a fix for that