Eliminate code duplicates in adapters.py#107
Open
EsipovPA wants to merge 1 commit intodsoprea:masterfrom
Open
Conversation
Signed-off-by: EsipovPA <esipov.p@mail.ru>
dsoprea
requested changes
Jul 7, 2025
| for entry_path in path_list: | ||
| if entry_path.is_dir(): | ||
| self._i.add_watch(str(entry_path), self._mask) | ||
| for sub_entry_path in entry_path.rglob('*'): |
Owner
There was a problem hiding this comment.
Let's just stick with listdir(), which is going to be much more efficient.
Also, it'd be better to do (for example):
if entry_path.is_dir() is False:
continue
..which will reduce nesting.
| "adding a watch on it (because we're " | ||
| "being recursive): [%s]", full_path) | ||
|
|
||
|
|
| import time | ||
|
|
||
| from errno import EINTR | ||
| from typing import List |
Owner
There was a problem hiding this comment.
It's probably fine to use native lists for the type hints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should resolve this issue: #106
Removed code duplicates.