Skip to content

prevent false positives in detecting internal errors#61

Merged
Tmonster merged 1 commit into
duckdb:mainfrom
c-herrewijn:prevent-false-positives
Dec 3, 2025
Merged

prevent false positives in detecting internal errors#61
Tmonster merged 1 commit into
duckdb:mainfrom
c-herrewijn:prevent-false-positives

Conversation

@c-herrewijn
Copy link
Copy Markdown
Member

fixes: https://github.com/duckdblabs/duckdb-internal/issues/6745

duckdb uses exit status 1 for both regular and internal errors.

This PR applies the following logic (in order) do distinguish between regular and internal errors:

  1. If the error string contains any of INTERNAL_ERROR_STRINGS -> always consider it an internal error
  2. if the error string contains any of the INTERNAL_ERROR_FALSE_POSITIVES -> consider it NOT an internal error
  3. if the error string contains string internal, consider it an internal error

Rule 3 can be considered a fall-back for ambiguous cases. In these cases, a potential false positive is preferred over a false negative

Comment thread scripts/fuzzer_helper.py
@Tmonster Tmonster merged commit 2144df0 into duckdb:main Dec 3, 2025
23 checks passed
@c-herrewijn c-herrewijn deleted the prevent-false-positives branch December 4, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants