Cpp17 fixes#67
Merged
Merged
Conversation
Member
c-herrewijn
commented
Mar 17, 2026
c-herrewijn
commented
- Apply patch from PR bumping duckdb/duckdb to cpp17:
- Bumping C++ Standard to 17 duckdb#21310
- patch
- Bump duckdb submodule to latest commit in main branch, to be C++17 compatible as well
Tmonster
reviewed
Mar 17, 2026
Member
Tmonster
left a comment
Tmonster
left a comment
There was a problem hiding this comment.
lgtm except for the settings.json of the .vscode
fixes error: cannot find 'ld' see: duckdb/duckdb#21139
Member
|
Thanks! |
c-herrewijn
added a commit
to c-herrewijn/duckdb
that referenced
this pull request
Mar 18, 2026
patch applied in: duckdb/duckdb-sqlsmith#67
Mytherin
added a commit
to duckdb/duckdb
that referenced
this pull request
Mar 20, 2026
patch applied in: duckdb/duckdb-sqlsmith#67
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.