Updating the server and ejs to use Collectibles updated endpoint with…#19
Updating the server and ejs to use Collectibles updated endpoint with…#19Alinda70 wants to merge 1 commit into
Conversation
… the image url and other data. OpenSea API is no longer necessary.
PR SummaryLow Risk Overview The collectibles UI no longer links out to Written by Cursor Bugbot for commit 4b6ea92. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
| return { | ||
| ...collectible, | ||
| // Use collection_name field, fallback to name if not available | ||
| collection_name: collectible.name || `Token #${collectible.token_id}` |
There was a problem hiding this comment.
API collection_name field overwritten by name fallback
Medium Severity
The comment on line 150 says "Use collection_name field, fallback to name if not available," but the code sets collection_name to collectible.name instead of collectible.collection_name. Although ...collectible spreads any existing collection_name from the API response, the explicit assignment on this line immediately overwrites it with collectible.name. The intended fallback chain is likely collectible.collection_name || collectible.name || ....


… the image url and other data. OpenSea API is no longer necessary.