Skip to content

Updating the server and ejs to use Collectibles updated endpoint with…#19

Open
Alinda70 wants to merge 1 commit into
duneanalytics:mainfrom
Alinda70:collectibles-tab-update
Open

Updating the server and ejs to use Collectibles updated endpoint with…#19
Alinda70 wants to merge 1 commit into
duneanalytics:mainfrom
Alinda70:collectibles-tab-update

Conversation

@Alinda70
Copy link
Copy Markdown

… the image url and other data. OpenSea API is no longer necessary.

… the image url and other data. OpenSea API is no longer necessary.
@cursor
Copy link
Copy Markdown

cursor Bot commented Feb 11, 2026

PR Summary

Low Risk
Removes an external dependency and simplifies data flow; main risk is reduced UX (no OpenSea links) or fewer collectibles shown due to filtering on missing image_url.

Overview
Collectibles fetching is simplified to rely solely on the Sim collectibles endpoint output, removing the per-NFT OpenSea lookup and returning only items that already include an image_url.

The collectibles UI no longer links out to opensea_url, and instead always renders a non-clickable collectible tile while continuing to display the image and a derived collection_name/token id label.

Written by Cursor Bugbot for commit 4b6ea92. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment @cursor review or bugbot run to trigger another review on this PR

Comment thread wallet-ui/server.js
return {
...collectible,
// Use collection_name field, fallback to name if not available
collection_name: collectible.name || `Token #${collectible.token_id}`
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API collection_name field overwritten by name fallback

Medium Severity

The comment on line 150 says "Use collection_name field, fallback to name if not available," but the code sets collection_name to collectible.name instead of collectible.collection_name. Although ...collectible spreads any existing collection_name from the API response, the explicit assignment on this line immediately overwrites it with collectible.name. The intended fallback chain is likely collectible.collection_name || collectible.name || ....

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants