Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds CSS styling to fix width/overflow issues with code blocks in the react-github-permalink component. The changes implement a Stack Overflow solution to properly constrain pre elements within the .rgp-base container.
- Adds nested CSS rules targeting pre elements within
.rgp-baseusing CSS nesting syntax - Implements width constraints using
width: 0andmin-width: calc(100% - 2em)with!importantflags - Includes commented-out code showing alternative approaches that were considered
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/app/globals.css
Outdated
| display: block; | ||
| overflow-x: auto; | ||
| white-space: pre-wrap !important; | ||
| /* max-width: calc(100% - 150px); */ |
There was a problem hiding this comment.
Commented-out code should be removed before merging to production. If this alternative solution needs to be preserved for reference, consider documenting why it was rejected or move it to commit history.
| /* max-width: calc(100% - 150px); */ |
src/app/globals.css
Outdated
| /* .rgp-base { | ||
| max-width: 60%; | ||
| } */ | ||
|
|
There was a problem hiding this comment.
Commented-out code should be removed before merging to production. If this alternative solution needs to be preserved for reference, consider documenting why it was rejected or move it to commit history.
| /* .rgp-base { | |
| max-width: 60%; | |
| } */ |
src/app/globals.css
Outdated
| /* .link-wrapper { | ||
| max-width: 300px; | ||
| } */ |
There was a problem hiding this comment.
Commented-out code should be removed before merging to production. If this alternative solution needs to be preserved for reference, consider documenting why it was rejected or move it to commit history.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
|
@dwjohnston I've opened a new pull request, #259, to work on those changes. Once the pull request is ready, I'll request review from you. |
b7b7944 to
24b7799
Compare
No description provided.