Add Goose skills support (.goose/skills/)

[github-actions]

Implementation complete. I've added Goose skills support with the following changes:

1. src/features/skills/goose-skill.ts - New GooseSkill class that:

   • Generates skills to .goose/skills/<name>/SKILL.md
   • Follows the Agent Skills specification with name and description frontmatter
   • Supports project scope only (no global mode)
   • Targeted by "goose" or "*" in rulesync skill targets

2. src/features/skills/skills-processor.ts - Registered goose target in:

   • skillsProcessorToolTargetTuple
   • toolSkillFactories map with supportsProject: true, supportsSimulated: false, supportsGlobal: false

3. src/features/skills/goose-skill.test.ts - 13 tests covering all methods

4. src/features/skills/skills-processor.test.ts - Updated expected targets to include goose

Closes #1115

github run

[dyoshikawa]

\oc レビューお願い

[dyoshikawa]

/oc レビューお願い

[dyoshikawa]

/oc #1149 (comment) このレビューコメントの指摘を修正してください。

[dyoshikawa]

/oc review

[dyoshikawa]

/oc review

[dyoshikawa]

/oc review

[dyoshikawa]

/oc review

[dyoshikawa]

/oc review

[dyoshikawa-claw]

/opencode review

[dyoshikawa]

/oc review

[dyoshikawa]

/oc review

[github-actions]

PR #1149 Review: Add Goose Skills Support

Code Review Summary ✅

Assessment: APPROVE - Ready to merge

1. Pattern Adherence ✅ - GooseSkill class follows established patterns (CopilotSkill, ClaudecodeSkill)
2. Code Quality ✅ - Uses z.looseObject(), join() from node:path, formatError() per coding guidelines
3. Registration ✅ - Correct metadata in skills-processor.ts: supportsProject: true, supportsSimulated: false, supportsGlobal: false
4. Test Coverage ✅ - 13 tests covering all methods, follows testing guidelines
5. Documentation ✅ - Accurate file formats and supported-tools tables
6. Minor Suggestion - Consider adding test for invalid YAML frontmatter in fromDir

Security Review Summary ✅

Assessment: LOW RISK - APPROVED

7. Path Traversal ✅ - Protected via AiDir base class (rejects path separators, validates resolved paths)
8. Input Validation ✅ - Zod schema + name-directory consistency check
9. Global Mode ✅ - Correctly throws error for unsupported mode
10. Injection Vulnerabilities ✅ - None found (no shell execution, safe file APIs)
11. Error Handling ✅ - Proper propagation with context
12. Optional - Add explicit path traversal test for GooseSkill (low priority)
13. Optional - Consider path validation for otherFiles in DirFeatureProcessor (defense-in-depth)

PR Number: #1149

Recommendation: Merge ready. All quality checks passed.

github run