Conversation
joaopedrodcf
left a comment
joaopedrodcf
left a comment
There was a problem hiding this comment.
Nice that you noticed this was not protected in CI and fixed it here 🙏
| - name: Build | ||
| run: npm run build | ||
| - name: Lint | ||
| run: npm run lint |
There was a problem hiding this comment.
can you explain this one?
lint already runs both. im not sure we need individual steps
There was a problem hiding this comment.
It just makes it easier to see which part failed in overview
There was a problem hiding this comment.
the risk is that we add a third lint script in future and have to remember to add it here. having it in one means we don't need to remember that.
thoughts?
There was a problem hiding this comment.
the risk is that we add a third lint script in future and have to remember to add it here. having it in one means we don't need to remember that.
thoughts?
True, but might be it is a good idea to have those decoupled
We already do that in npmx, for example
4 participants
🔗 Linked issue
See #312 (comment)
📚 Description