fix(js-sdk): preserve multi-source COPY in fromDockerfile#1354
fix(js-sdk): preserve multi-source COPY in fromDockerfile#1354serejaris wants to merge 1 commit into
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @serejaris on file. You can sign our CLA at https://e2b.dev/docs/cla . Once you've signed, post a comment here that says '@cla-bot check' |
🦋 Changeset detectedLatest commit: fdf1d17 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Closing this as superseded by #1355.\n\nI compared the two PRs: this branch only covers the JS path and is still CLA-blocked, while #1355 covers both JS and Python , includes the multi-source COPY/ADD regressions in both SDKs, and has the maintainer-owned checks/CLA path.\n\nThanks for picking this up; I will track #1355 instead. |
|
Small correction to the comparison above: this branch covers the JS |
Summary
Template().fromDockerfile()dropping all but the first source in multi-source DockerfileCOPYinstructions.COPYstep per source while preserving the shared destination and COPY flags like--chown.Fixes #1349
Test plan
pnpm --filter e2b exec vitest run tests/template/methods/fromDockerfile.test.ts -t "multi-source COPY"pnpm --filter e2b exec vitest run tests/template/methods/fromDockerfile.test.tspnpm --filter e2b run typecheckpnpm --filter e2b run lintpnpm --filter e2b run buildpnpm --filter e2b exec prettier --check src/template/dockerfileParser.ts tests/template/methods/fromDockerfile.test.ts