Skip to content

chore(spec): add prettier yaml formatting check to lint workflow#1358

Merged
mishushakov merged 1 commit into
mainfrom
mishushakov/lint-yaml-formatting
May 27, 2026
Merged

chore(spec): add prettier yaml formatting check to lint workflow#1358
mishushakov merged 1 commit into
mainfrom
mishushakov/lint-yaml-formatting

Conversation

@mishushakov
Copy link
Copy Markdown
Member

Summary

  • Add spec/ to the pnpm workspace with a package.json that runs prettier --check/--write on openapi.yml and envd/envd.yaml.
  • The existing Lint workflow's recursive pnpm run lint/pnpm run format now enforces YAML formatting automatically — no workflow changes needed.
  • Reformat spec/openapi.yml (two $ref quote-style changes) so the new check passes.

Test plan

  • CI Lint workflow passes
  • pnpm --filter @e2b/spec run lint succeeds locally

🤖 Generated with Claude Code

Adds the spec/ directory to the pnpm workspace with a package.json that
runs prettier on openapi.yml and envd/envd.yaml, so the existing Lint
workflow picks up YAML formatting via the recursive lint/format scripts.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@cursor
Copy link
Copy Markdown

cursor Bot commented May 27, 2026

PR Summary

Low Risk
Tooling and cosmetic YAML quote normalization only; no runtime API or application logic changes.

Overview
Adds spec/ as a pnpm workspace package (@e2b/spec) with Prettier lint / format scripts for openapi.yml and envd/envd.yaml, so the existing recursive pnpm run lint / format in CI now enforces YAML style on API specs without workflow edits.

pnpm-lock.yaml picks up the new workspace devDependency. spec/openapi.yml is adjusted in two places (double-quoted → single-quoted $ref values) so the new check passes.

Reviewed by Cursor Bugbot for commit ff175d7. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 27, 2026

⚠️ No Changeset found

Latest commit: ff175d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

Package Artifacts

Built from 63ab5c8. Download artifacts from this workflow run.

JS SDK (e2b@2.26.1-mishushakov-lint-yaml-formatting.0):

npm install ./e2b-2.26.1-mishushakov-lint-yaml-formatting.0.tgz

CLI (@e2b/cli@2.10.3-mishushakov-lint-yaml-formatting.0):

npm install ./e2b-cli-2.10.3-mishushakov-lint-yaml-formatting.0.tgz

Python SDK (e2b==2.24.0+mishushakov-lint-yaml-formatting):

pip install ./e2b-2.24.0+mishushakov.lint.yaml.formatting-py3-none-any.whl

Copy link
Copy Markdown
Contributor

@matthewlouisbrockman matthewlouisbrockman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moar linter!

@mishushakov mishushakov merged commit e091e03 into main May 27, 2026
26 checks passed
@mishushakov mishushakov deleted the mishushakov/lint-yaml-formatting branch May 27, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants