Feature/add testing project and refactor jsoncanonicalizer#2
Open
Freezor wants to merge 18 commits intoeclipse-aaspe:mainfrom
Open
Feature/add testing project and refactor jsoncanonicalizer#2Freezor wants to merge 18 commits intoeclipse-aaspe:mainfrom
Freezor wants to merge 18 commits intoeclipse-aaspe:mainfrom
Conversation
Author
|
@martafullen I created a unit test project and changelog for the commons module, so we can improve that common module and maybe get a better base for the package explorer and the server. This PR is my idea for a better structure. Let's discuss what you think about it. |
Contributor
|
I will have a looky 🙃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes a series of refactoring changes and enhancements to improve code readability, maintainability, and test coverage for the
JsonCanonicalizerclass. The changes address several aspects, including method extraction, naming improvements, and the addition of comprehensive unit tests.Motivation and Context
Fixes # (issue)
Type of change
How Has This Been Tested?
Screenshots (if appropriate):
N/A
Checklist: