Fix nullable and error handling in AASXFileServerAPIApiController#339
Open
Freezor wants to merge 4 commits intoeclipse-aaspe:mainfrom
Open
Conversation
Contributor
|
Hi @Freezor, I tried to test the PR. All the APIs in File Server IF work fine, except for Get /Packages. It returns 406 error code with the warning message in the logs: "No output formatter was found for content types '' to write the response.". Ideally, it should return paginated result with a list of packageIds & aasIds, i.e., list of "PackageDescription". The functionaloty was working as expected earlier, so something must have changed during refactoring.
I would really appreciate, if you could look into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed the nullable handling to represent the logic that was present before the .Net8.0 change. Also made sure that no new exceptions are thrown based on the nullable changes