Skip to content

fix: remove erroneous len guard that broke multi globalAssetId filtering #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
algojogacor wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −2
Open

fix: remove erroneous len guard that broke multi globalAssetId filtering #546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions server/app/interfaces/repository.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,7 @@ def _get_shells(self, request: Request) -> Tuple[Iterator[model.AssetAdministrat
aas = filter(lambda shell: (
(not specific_asset_ids or all(specific_asset_id in shell.asset_information.specific_asset_id
for specific_asset_id in specific_asset_ids)) and
(len(global_asset_ids) <= 1 and
(not global_asset_ids or shell.asset_information.global_asset_id in global_asset_ids))
(not global_asset_ids or shell.asset_information.global_asset_id in global_asset_ids)
), aas)

paginated_aas, end_index = self._get_slice(request, aas)
Expand Down