Skip to content

Conversation

@al-noori
Copy link
Contributor

All usages of the stated constructor with an additional GC initialization are now replaced by an ImageGcDrawer and the Image(device, gc int, int) constructor afterwards in examples/graphics.

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

examples/org.eclipse.swt.examples/META-INF/MANIFEST.MF

Warning

🚧 This PR cannot be modified by maintainers because edits are disabled or it is created from an organization repository. To obtain the required changes apply the git patch manually as an additional commit.

Git patch
From c70177da5710501e5a627a684f7c18b0091c3614 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Mon, 1 Dec 2025 10:18:24 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/examples/org.eclipse.swt.examples/META-INF/MANIFEST.MF b/examples/org.eclipse.swt.examples/META-INF/MANIFEST.MF
index 9b80453c74..98a229b574 100644
--- a/examples/org.eclipse.swt.examples/META-INF/MANIFEST.MF
+++ b/examples/org.eclipse.swt.examples/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %plugin.SWTStandaloneExampleSet.name
 Bundle-SymbolicName: org.eclipse.swt.examples; singleton:=true
-Bundle-Version: 3.108.1000.qualifier
+Bundle-Version: 3.108.1100.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Bundle-RequiredExecutionEnvironment: JavaSE-17
-- 
2.51.2

Further information are available in Common Build Issues - Missing version increments.

@akoch-yatta akoch-yatta force-pushed the al-noori/ReplaceImagegcDrawerInGraphics branch from 9b40ab7 to 68200d6 Compare December 1, 2025 10:23
@akoch-yatta
Copy link
Contributor

If I try this PR on a setup 100% primary, 175% secondary I get the following issue:
image

To reproduce:

  1. Open the ControlExample (with vm args -Dswt.autoScale=quarter -Dswt.autoScale.updateOnRuntime=true) (on primary)
  2. Open Tree Tab
  3. Change background color in "Colors and Fonts"
  4. Move to secondary monitor

I get the same effect on master, when I change the color, while being on the secondary monitor, but it is happening now on DPI change as well (because the handle is now recreated in that scenario as well)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Test Results

  176 files  + 7    176 suites  +7   26m 34s ⏱️ - 3m 31s
4 684 tests +57  4 662 ✅ +55  22 💤 +3  0 ❌  - 1 
  485 runs  +57    479 ✅ +54   6 💤 +3  0 ❌ ±0 

Results for commit ee5ef6c. ± Comparison against base commit 9acbc6f.

♻️ This comment has been updated with latest results.

@HeikoKlare
Copy link
Contributor

I get the same effect on master, when I change the color, while being on the secondary monitor, but it is happening now on DPI change as well (because the handle is now recreated in that scenario as well)

@akoch-yatta If I understand correctly, you refer to the mismatch between box and it filling, don't you? Should we create a separate ticket for it?

@akoch-yatta akoch-yatta force-pushed the al-noori/ReplaceImagegcDrawerInGraphics branch from 68200d6 to 223bd30 Compare December 4, 2025 08:12
@amartya4256 amartya4256 force-pushed the al-noori/ReplaceImagegcDrawerInGraphics branch from 223bd30 to 170a372 Compare January 29, 2026 12:37
@akoch-yatta akoch-yatta force-pushed the al-noori/ReplaceImagegcDrawerInGraphics branch from 170a372 to 9e97a0a Compare January 29, 2026 14:23
@amartya4256 amartya4256 force-pushed the al-noori/ReplaceImagegcDrawerInGraphics branch 2 times, most recently from 9e8ca9a to 8d58f53 Compare January 29, 2026 17:43
Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amartya4256 can you please reduce this one to what's not covered by:

@akoch-yatta akoch-yatta force-pushed the al-noori/ReplaceImagegcDrawerInGraphics branch 2 times, most recently from 83d2b5d to 61122b4 Compare January 30, 2026 07:34
@akoch-yatta
Copy link
Contributor

@HeikoKlare I removed those and rebased the branch on master

@akoch-yatta akoch-yatta force-pushed the al-noori/ReplaceImagegcDrawerInGraphics branch 2 times, most recently from 84f9d33 to a773b74 Compare January 30, 2026 08:39
All usages of the stated constructor with an additional GC initialization
are now replaced by an ImageGcDrawer and the Image(device, gc int, int)
constructor afterwards in GraphicsExample.

Co-authored-by:  Amartya Parijat <amartya.parijat@yatta.de>
@al-noori al-noori force-pushed the al-noori/ReplaceImagegcDrawerInGraphics branch from a773b74 to ee5ef6c Compare January 30, 2026 09:23
@HeikoKlare HeikoKlare merged commit 87f04f3 into eclipse-platform:master Jan 30, 2026
23 checks passed
@HeikoKlare HeikoKlare deleted the al-noori/ReplaceImagegcDrawerInGraphics branch January 30, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace Image(device,int,int) constructor in examples/graphics

4 participants