-
Notifications
You must be signed in to change notification settings - Fork 190
Replacement of Image(device, int, int) constructor in examples/graphics #2828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacement of Image(device, int, int) constructor in examples/graphics #2828
Conversation
80836a4 to
9b40ab7
Compare
|
This pull request changes some projects for the first time in this development cycle. Warning 🚧 This PR cannot be modified by maintainers because edits are disabled or it is created from an organization repository. To obtain the required changes apply the git patch manually as an additional commit. Git patchFurther information are available in Common Build Issues - Missing version increments. |
9b40ab7 to
68200d6
Compare
@akoch-yatta If I understand correctly, you refer to the mismatch between box and it filling, don't you? Should we create a separate ticket for it? |
68200d6 to
223bd30
Compare
223bd30 to
170a372
Compare
170a372 to
9e97a0a
Compare
9e8ca9a to
8d58f53
Compare
HeikoKlare
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amartya4256 can you please reduce this one to what's not covered by:
83d2b5d to
61122b4
Compare
|
@HeikoKlare I removed those and rebased the branch on master |
84f9d33 to
a773b74
Compare
examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/graphics/GraphicsExample.java
Outdated
Show resolved
Hide resolved
examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/graphics/GraphicsExample.java
Outdated
Show resolved
Hide resolved
All usages of the stated constructor with an additional GC initialization are now replaced by an ImageGcDrawer and the Image(device, gc int, int) constructor afterwards in GraphicsExample. Co-authored-by: Amartya Parijat <amartya.parijat@yatta.de>
a773b74 to
ee5ef6c
Compare

All usages of the stated constructor with an additional GC initialization are now replaced by an ImageGcDrawer and the Image(device, gc int, int) constructor afterwards in examples/graphics.