Skip to content

Test the validity of configuration element before accessing attributes#2600

Merged
merks merged 2 commits into
eclipse-platform:masterfrom
eric-milles:issue2593
May 14, 2026
Merged

Test the validity of configuration element before accessing attributes#2600
merks merged 2 commits into
eclipse-platform:masterfrom
eric-milles:issue2593

Conversation

@eric-milles
Copy link
Copy Markdown
Contributor

@eric-milles eric-milles commented Apr 1, 2026

The IConfigurationElement.getAttribute method throws InvalidRegistryObjectException. Check isValid() before accessing attributes to prevent uncaught exception.

see #2593

@eric-milles eric-milles force-pushed the issue2593 branch 3 times, most recently from a85e167 to 064eb24 Compare April 3, 2026 14:10
@eric-milles
Copy link
Copy Markdown
Contributor Author

[ERROR] Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:5.0.3-SNAPSHOT:compare-version-with-baselines (compare-attached-artifacts-with-release) on project org.eclipse.core.expressions: Only qualifier changed for (org.eclipse.core.expressions/3.9.500.v20260403-1410). Expected to have bigger x.y.z than what is available in baseline (3.9.500.v20250608-0434)

Is this something that is supposed to be changed elsewhere? Or is the expectation that I bump the version?

@eric-milles
Copy link
Copy Markdown
Contributor Author

There is still not a version difference in the current master branch. Am I supposed to bump the version in the manifest?

@eric-milles
Copy link
Copy Markdown
Contributor Author

@iloveeclipse Can you help with the version issue that fails the build?

@merks
Copy link
Copy Markdown
Contributor

merks commented May 14, 2026

I tried rebasing. Maybe that helps.

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

runtime/bundles/org.eclipse.core.expressions/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 7772fc531e16e14c65bac0a9ae80f7b106535284 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Thu, 14 May 2026 19:16:16 +0000
Subject: [PATCH] Version bump(s) for 4.40 stream


diff --git a/runtime/bundles/org.eclipse.core.expressions/META-INF/MANIFEST.MF b/runtime/bundles/org.eclipse.core.expressions/META-INF/MANIFEST.MF
index 6df4865eeb..53ee9d9327 100644
--- a/runtime/bundles/org.eclipse.core.expressions/META-INF/MANIFEST.MF
+++ b/runtime/bundles/org.eclipse.core.expressions/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.core.expressions; singleton:=true
-Bundle-Version: 3.9.500.qualifier
+Bundle-Version: 3.9.600.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Export-Package: org.eclipse.core.expressions,
-- 
2.54.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

Test Results

    54 files  ±0      54 suites  ±0   37m 13s ⏱️ -20s
 4 667 tests +1   4 645 ✅ +2   22 💤 ±0  0 ❌  - 1 
11 895 runs  +3  11 742 ✅ +4  153 💤 ±0  0 ❌  - 1 

Results for commit 11dc31f. ± Comparison against base commit 8bfe3ed.

@merks merks merged commit 8ff8fb7 into eclipse-platform:master May 14, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants