Replace InfiniteSubProgressMonitor with SubMonitor in org.eclipse.team.core#2660
Draft
vogella wants to merge 2 commits into
Draft
Replace InfiniteSubProgressMonitor with SubMonitor in org.eclipse.team.core#2660vogella wants to merge 2 commits into
vogella wants to merge 2 commits into
Conversation
SubMonitor's proportional scaling handles the same use case as InfiniteSubProgressMonitor without the custom halving algorithm. The anonymous SubProgressMonitor subclass in SubscriberSyncInfoEventHandler is replaced with ProgressMonitorWrapper, which allows the same override-and-delegate pattern without subclassing the deprecated class. Removes InfiniteSubProgressMonitor and the infiniteSubMonitorFor helper in Policy since both are internal and unused after this change.
vogella
force-pushed
the
replace-infinite-sub-progress-monitor
branch
from
f35d4ac to
c75e9ff
Compare
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Planned for 4.41
InfiniteSubProgressMonitorwas an internal class inorg.eclipse.team.corethat worked around the oldSubProgressMonitorlimitation of overshooting allocated parent ticks.SubMonitor's built-in proportional scaling handles this naturally, making the custom halving algorithm unnecessary.This removes
InfiniteSubProgressMonitor, theinfiniteSubMonitorForhelper inPolicy, and replaces the two call sites inBackgroundEventHandlerandAbstractResourceVariantTreewith directSubMonitorusage.