Draft
Conversation
marwan275
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
Contributor
|
Marking as draft, until basic build works. |
marwan275
force-pushed
the
moma_use_std
branch
4 times, most recently
from
76cf49b to
a355a4b
Compare
- Replace score::cpp::optional with std::optional in all tracing
interfaces, mocks, and tests
- Add std::optional to score::cpp::optional conversion bridge in
tracing_runtime.cpp for baselibs API compatibility
- Replace static_cast<EventIdType/FieldIdType>() with brace init
EventIdType{}/FieldIdType{} in lola tracing runtime and test
- Migrate to StdVariantType with EventId{} struct wrapper
- Revert std::get_if/std::get to score::cpp::get_if/score::cpp::get
where MetaInfoVariants::Type (score::cpp::variant) is used
- Remove #include <score/optional.hpp>, add #include <optional>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the
mw/comtracing code to use the new type-safeServiceInstanceElementinterface introduced in eclipse-score/baselibs#be21786.Motivation
The migration from
score::cpp::variant(amp::variant) tostd::variantrequires distinct struct types for variant alternatives sincestd::variantcannot distinguish between multipleuint32_taliases. The baselibs repository introduced new wrapper structs (EventId,FieldId,MethodId) alongside aStdVariantTypealias forstd::variant<EventId, FieldId, MethodId>.Changes
score::cpp::optional<T>std::optional<T>score::cpp::get_if<T>()std::get_if<T>()ServiceInstanceElement::EventIdTypeServiceInstanceElement::EventId(struct)ServiceInstanceElement::FieldIdTypeServiceInstanceElement::FieldId(struct)ServiceInstanceElement::VariantTypeServiceInstanceElement::StdVariantTypeEventIdType = 42UEventId{42U}Dependencies
Testing
All existing unit tests updated to use the new interface.