Rust::com Integration test cases for Rust COM-API by bharatGoswami8 · Pull Request #237 · eclipse-score/communication

bharatGoswami8 · 2026-03-25T06:21:10Z

Added integration test cases to verify data type and size of type for primitive and user defined struct

arvindr19 · 2026-03-31T04:51:19Z

score/mw/com/test/basic_rust_api/consumer_async_apis/integration_test/BUILD

    name = "filesystem",
    deps = [
-        "//score/mw/com/test/com_api/consumer_async_apis:bigdata-com-api-async-pkg",
+        "//score/mw/com/test/basic_rust_api/consumer_async_apis:bigdata-com-api-async-pkg",


Question: what basic_rust_api means?

it is a folder name where we kept rust com api related integration tests, keeping name com-api is so generic.

score/mw/com/test/basic_rust_api/bigdata_com_api_gen.h

score/mw/com/test/basic_rust_api/consumer_sync_apis/consumer_app.rs

darkwisebear · 2026-04-07T19:54:01Z

score/mw/com/test/basic_rust_api/bigdata_com_api_gen.rs

+// Test for primitive and complex data types, used in the com-api integration tests.
+
+// Macro to generate data types with CommData impl with Eq trait
+macro_rules! define_type {


Imo the macro should be changed slightly to be closer to the regular struct definition of Rust. This makes the code more readable.

added the struct literal on macro parameter.

Seems picky but why #[eq] and not #[derive($($trait:name),+)]? This way, you a) stick to the conventions of Rust and b) enable extra traits to be derived.

Added suggest changes.

darkwisebear · 2026-04-07T19:56:01Z

score/mw/com/test/basic_rust_api/bigdata_com_api_gen.h

+};
+
+// Macro to generate interface classes
+#define CREATE_INTERFACE(ClassName, DataType, EventName)                       \


Imo the definition of a macro isn't worth the deduplication. Please remove this one.

Removed and changed to each interface class.

darkwisebear · 2026-04-07T20:02:45Z

score/mw/com/test/basic_rust_api/consumer_sync_apis/consumer_app.rs

+
+    match args.test_case {
+        // The bigdata test uses the `BigDataInterface` and its `map_api_lanes_stamped_` event.
+        TestCase::Bigdata => {


Please move the match arms to separate functions.

darkwisebear · 2026-04-07T20:03:41Z

score/mw/com/test/basic_rust_api/producer_app/producer_app.rs

+
+    match args.test_case {
+        // The bigdata test uses the `BigDataInterface` and its `map_api_lanes_stamped_` event.
+        TestCase::Bigdata => {


Move match arms to separate functions.

darkwisebear · 2026-04-08T11:55:03Z

score/mw/com/test/basic_rust_api/bigdata_com_api_gen.rs

+// Test for primitive and complex data types, used in the com-api integration tests.
+
+// Macro to generate data types with CommData impl with Eq trait
+macro_rules! define_type {


Seems picky but why #[eq] and not #[derive($($trait:name),+)]? This way, you a) stick to the conventions of Rust and b) enable extra traits to be derived.

darkwisebear · 2026-04-08T11:56:57Z

score/mw/com/test/basic_rust_api/bigdata_com_api_gen.rs

+        #[repr(C)]
+        pub struct $name {
+            $(pub $field: $field_type,)*
+        }
+        impl CommData for $name {
+            const ID: &'static str = stringify!($name);
+        }


This could be deduplicated by introducing another macro. You can forward a whole AST part by using the tt matcher, along with the list of derive traits.

Agreed, added helper macro define_com_type_impl.

darkwisebear · 2026-04-08T11:58:11Z

score/mw/com/test/basic_rust_api/bigdata_com_api_gen.rs

+// Test for primitive and complex data types, used in the com-api integration tests.
+
+// Macro to generate data types with CommData impl with Eq trait
+macro_rules! define_type {


define_type is super super generic. Can you change the name to reflect what its doing with that type? E.g. define_com_type?

* Added integration test cases to verify data type and size of type for primitive and user defined struct

* Created macro for primitive and user-defined struct * created macro for genrated files

* Updated one test case for all the primitive types

* Updated complex struct test case

* Added primitive and complex struct

* Updated test cases and data types

* Updated test cases

* Updated type macro

bharatGoswami8 requested review from LittleHuba, bemerybmw, castler, crimson11, hoe-jo and limdor as code owners March 25, 2026 06:21

bharatGoswami8 self-assigned this Mar 25, 2026

bharatGoswami8 added the rust-api label Mar 25, 2026

bharatGoswami8 force-pushed the integration_test_cases branch 4 times, most recently from 9b2c413 to 297ffad Compare March 26, 2026 08:45

bharatGoswami8 marked this pull request as draft March 26, 2026 11:04

bharatGoswami8 force-pushed the integration_test_cases branch 3 times, most recently from 982dc4b to d5ff26c Compare March 31, 2026 04:41

bharatGoswami8 marked this pull request as ready for review March 31, 2026 04:41

bharatGoswami8 requested a review from darkwisebear March 31, 2026 04:44

bharatGoswami8 force-pushed the integration_test_cases branch from d5ff26c to 69394d6 Compare March 31, 2026 04:52

bharatGoswami8 changed the title ~~Rust::com Integration test cases for COM-API using rust-test~~ Rust::com Integration test cases for Rust COM-API Mar 31, 2026

arvindr19 reviewed Mar 31, 2026

View reviewed changes

darkwisebear reviewed Apr 7, 2026

View reviewed changes

bharatGoswami8 force-pushed the integration_test_cases branch from 63c060a to 5189a40 Compare April 8, 2026 10:13

bharatGoswami8 requested review from arvindr19 and darkwisebear April 8, 2026 10:14

darkwisebear reviewed Apr 8, 2026

View reviewed changes

bharatGoswami8 force-pushed the integration_test_cases branch 2 times, most recently from 20ca61b to 5c83fbc Compare April 8, 2026 14:12

darkwisebear approved these changes Apr 8, 2026

View reviewed changes

Rust::com Integration test cases for primitive and user defined type

acabd76

* Added integration test cases to verify data type and size of type for primitive and user defined struct

bharatGoswami8 added 7 commits April 8, 2026 17:42

Rust::com Created macro for test-case

39eee67

* Created macro for primitive and user-defined struct * created macro for genrated files

Rust::com Integration test case update

69fc621

* Updated one test case for all the primitive types

Rust::com Update the test cases

a3e40fc

* Updated complex struct test case

Rust::com Add integration test for validating CPP and rust memory

fcda669

* Added primitive and complex struct

Rust::com Integration test case update for rust apis

2bbb4c1

* Updated test cases and data types

Rust::com Integration test case for rust apis

c88e7c9

* Updated test cases

Rust::com Intergration test case update for rust API

63d9c6f

* Updated type macro

bharatGoswami8 force-pushed the integration_test_cases branch from 5c83fbc to 63d9c6f Compare April 8, 2026 15:42

castler approved these changes Apr 9, 2026

View reviewed changes

castler added this pull request to the merge queue Apr 9, 2026

Merged via the queue into eclipse-score:main with commit 5c233a9 Apr 9, 2026
8 checks passed

Conversation

bharatGoswami8 commented Mar 25, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants