lola: Extract skeleton shared memory functionality by bemerybmw · Pull Request #257 · eclipse-score/communication

bemerybmw · 2026-03-30T13:11:34Z

The Skeleton currently performs Skeleton specific functionality (e.g.
PrepareOffer, PrepareStopOffer(), managing instance / usage marker
files, managing method subscription etc.). It also performs all
functionality to create / open shared memory and also insert events into
the maps in shared memory.

This commit splits up the functionality so that we have a single class
which is responsible for interacting with shared memory. This makes the
code much easier to navigate since the old skeleton code was a huge
monolith and also will allow us to optionally split up our unit tests as
well into skeleton functionality and shared memory operations. We could
even introduce an interface for SkeletonMemoryManager to completely
decouple the skeleton functionality tests from shared memory.

For now, we treat Skeleton and SkeletonMemoryManager as a single unit,
so we don't test the public interface of SkeletonMemoryManager.

Depends-on: #247

The Skeleton currently performs Skeleton specific functionality (e.g. PrepareOffer, PrepareStopOffer(), managing instance / usage marker files, managing method subscription etc.). It also performs all functionality to create / open shared memory and also insert events into the maps in shared memory. This commit splits up the functionality so that we have a single class which is responsible for interacting with shared memory. This makes the code much easier to navigate since the old skeleton code was a huge monolith and also will allow us to optionally split up our unit tests as well into skeleton functionality and shared memory operations. We could even introduce an interface for SkeletonMemoryManager to completely decouple the skeleton functionality tests from shared memory. For now, we treat Skeleton and SkeletonMemoryManager as a single unit, so we don't test the public interface of SkeletonMemoryManager.

gdadunashvili · 2026-04-07T07:45:10Z

+namespace score::mw::com::impl::lola
+{
+
+/// \brief SkeletonMemoryManager manages are shared memory related functionality of a Skeleton.


Suggested change

/// \brief SkeletonMemoryManager manages are shared memory related functionality of a Skeleton.

/// \brief SkeletonMemoryManager manages shared memory related functionality of a Skeleton.

gdadunashvili · 2026-04-07T07:45:45Z

+
+/// \brief SkeletonMemoryManager manages are shared memory related functionality of a Skeleton.
+///
+/// A SkeletonMemoryManager is owned and dispatched to by a Skeleton.


Suggested change

/// A SkeletonMemoryManager is owned and dispatched to by a Skeleton.

/// A SkeletonMemoryManager is owned and dispatched by a Skeleton.

I'm not really clear what it means to be dispached by the skeleton? Does it just mean that it is used by the skeleton?

Yep. I use dispatch here to indicate the the Skeleton is basically just forwarding calls to this class and this class contains all the functionality. For me, "uses" could also be that this class contains some helper functions which the Skeleton uses, but the skeleton still has some logic related to shared memory. But if you think it's unclear, I can change it. Don't have a strong opinion.

gdadunashvili · 2026-04-07T07:48:07Z

+/// A SkeletonMemoryManager is owned and dispatched to by a Skeleton.
+class SkeletonMemoryManager final
+{
+    // Suppress "AUTOSAR C++14 A11-3-1", The rule declares: "Friend declarations shall not be used".


Maybe rephrase the direct quote of the rule.

Suppress "AUTOSAR C++14 A11-3-1", Forbids the use of friends declaration.

gdadunashvili · 2026-04-07T07:50:13Z

+class SkeletonMemoryManager final
+{
+    // Suppress "AUTOSAR C++14 A11-3-1", The rule declares: "Friend declarations shall not be used".
+    // The "SkeletonAttorney" class is a helper, which sets the internal state of "Skeleton" accessing


Suggested change

// The "SkeletonAttorney" class is a helper, which sets the internal state of "Skeleton" accessing

// The "SkeletonMemoryManagerTestAttorney" class is a helper, which sets the internal state of "Skeleton" accessing

gdadunashvili · 2026-04-07T16:31:18Z

+    class ShmResourceStorageSizes
+    {
+      public:
+        // Suppress "AUTOSAR C++14 M11-0-1" rule findings. This rule states: "Member data in non-POD class types shall


I would rephrase the direct quote of the rule

gdadunashvili · 2026-04-07T16:32:50Z

+auto SkeletonMemoryManager::OpenEventDataFromOpenedSharedMemory(const ElementFqId element_fq_id)
+    -> std::pair<EventDataStorage<SampleType>*, EventDataControlComposite<>>
+{
+    // Suppress "AUTOSAR C++14 A15-5-3" rule findings. This rule states: "The std::terminate() function shall not be


Also remove the direct quote here

gdadunashvili · 2026-04-07T16:35:52Z

+        // coverity[autosar_cpp14_a15_4_2_violation]
+        register_shm_object_trace_callback.value()(
+            tracing::TracingRuntime::kDummyElementNameForShmRegisterCallback,
+            // Suppress "AUTOSAR C++14 A4-5-1" rule findings. This rule states: "Expressions with type enum or enum


remove direct quote

gdadunashvili · 2026-04-07T16:46:45Z

+}
+
+template <typename SampleType>
+// Suppress "AUTOSAR C++14 M3-2-2" rule finding. This rule declares: "The One Definition Rule shall not be


rephrase the direct quote

gdadunashvili · 2026-04-07T16:47:04Z

+        event_data_control_asil_b = &(event_control_asil_b_it->second.data_control);
+    }
+
+    // Suppress "AUTOSAR C++14 A5-3-2" rule finding. This rule declares: "Null pointers shall not be dereferenced.".


rephrase the direct quote

gdadunashvili · 2026-04-07T16:47:22Z

+                                                "Could not get EventDataStorage*");
+
+    // Suppress "AUTOSAR C++14 A3-8-1" rule findings. This rule declares:
+    // "An object shall not be accessed outside of its lifetime"


rephrase direct quote

bemerybmw force-pushed the brem_skeleton_memory_manager branch 2 times, most recently from 8cb811d to 534e998 Compare March 31, 2026 14:05

bemerybmw marked this pull request as ready for review April 1, 2026 06:06

bemerybmw requested review from LittleHuba, castler, crimson11, hoe-jo and limdor as code owners April 1, 2026 06:06

bemerybmw force-pushed the brem_skeleton_memory_manager branch from 534e998 to 15b6693 Compare April 1, 2026 08:46

bemerybmw added 4 commits April 1, 2026 16:10

lola: Remove HasAsilBSupport

f4f4359

lola: Remove unused function

99d93e2

Move GetEventMetaInfo to attorney since only used in tests

addf2f1

bemerybmw force-pushed the brem_skeleton_memory_manager branch from 0f1f0fd to addf2f1 Compare April 1, 2026 14:11

gdadunashvili reviewed Apr 7, 2026

View reviewed changes

lola: Remove autosar rule finding quotes

13c11c6

gdadunashvili approved these changes Apr 8, 2026

View reviewed changes

LittleHuba approved these changes Apr 8, 2026

View reviewed changes

LittleHuba added this pull request to the merge queue Apr 8, 2026

Merged via the queue into main with commit 06e1257 Apr 8, 2026
13 checks passed

LittleHuba deleted the brem_skeleton_memory_manager branch April 8, 2026 13:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lola: Extract skeleton shared memory functionality#257

lola: Extract skeleton shared memory functionality#257
LittleHuba merged 5 commits intomainfrom
brem_skeleton_memory_manager

bemerybmw commented Mar 30, 2026

Uh oh!

gdadunashvili Apr 7, 2026

Uh oh!

gdadunashvili Apr 7, 2026

Uh oh!

gdadunashvili Apr 7, 2026

Uh oh!

bemerybmw Apr 8, 2026

Uh oh!

gdadunashvili Apr 7, 2026

Uh oh!

gdadunashvili Apr 7, 2026

Uh oh!

gdadunashvili Apr 7, 2026

Uh oh!

gdadunashvili Apr 7, 2026

Uh oh!

gdadunashvili Apr 7, 2026

Uh oh!

gdadunashvili Apr 7, 2026

Uh oh!

gdadunashvili Apr 7, 2026

Uh oh!

gdadunashvili Apr 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	/// \brief SkeletonMemoryManager manages are shared memory related functionality of a Skeleton.
	/// \brief SkeletonMemoryManager manages shared memory related functionality of a Skeleton.

	/// A SkeletonMemoryManager is owned and dispatched to by a Skeleton.
	/// A SkeletonMemoryManager is owned and dispatched by a Skeleton.

	// The "SkeletonAttorney" class is a helper, which sets the internal state of "Skeleton" accessing
	// The "SkeletonMemoryManagerTestAttorney" class is a helper, which sets the internal state of "Skeleton" accessing

Conversation

bemerybmw commented Mar 30, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants