Refactor Monitor API to public Alive API#229
Merged
NicolasFussberger merged 21 commits intoJun 22, 2026
Merged
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
MaciejKaszynski
suggested changes
Jun 8, 2026
pawelrutkaq
requested changes
Jun 9, 2026
Contributor
|
FT-Team meeting: 2026-06-10: The report_health_status api shall also provide the possibility to report "not ok" state to shorten FTTI times in some use-cases. |
Contributor
Author
Okay understood. Then I guess the C++ API would look like this: enum class HealthStatus : uint8_t {
kOk,
kNotOk
};
class Alive {
public:
void ReportHealthStatus(HealthStatus status);
};Though I am also wondering if having a separate method for the failure reporting would be more explicit. class Alive {
public:
void ReportAlive();
void ReportFailure();
};What do you think @pawelrutkaq @ramceb ? |
MaciejKaszynski
suggested changes
Jun 18, 2026
MaciejKaszynski
approved these changes
Jun 18, 2026
pawelrutkaq
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the Launch Manager "Monitor" interface to the Alive API.
Example usage:
Public bazel targets:
//score/launch_manager:alive_cc//score/launch_manager:alive_rustChanges:
Open Questions:
Closes: #149