angular: build against v20, allow v22 RC, inject() instead of constructor injection#2573
Open
lucas-koehler wants to merge 4 commits into
Open
angular: build against v20, allow v22 RC, inject() instead of constructor injection#2573lucas-koehler wants to merge 4 commits into
lucas-koehler wants to merge 4 commits into
Conversation
Reduce the risk of installing malicious packages when upgrading dependency versions by only allowing package versions published at least 72h ago. As most malicious packages are discovered and blocked within this time, this reduces the risk of accidentally installing them.
- Upgrade to TypeScript ~5.8.3 across all packages
- Fix vue-vuetify build for TypeScript 5.8.3
- Upgrade vue-tsc from ^2.0.11 to ^2.2.0: vue-tsc 2.0.x monkey-patches
a TypeScript internal string (`supportedTSExtensions`) that was removed
in TS 5.8, causing a crash. Version 2.1.0+ uses a compatible approach.
- Change type-check from `vue-tsc --build --force` to
`vue-tsc -p tsconfig.lib.json` and remove `composite: true` from
tsconfig.lib.json: `composite` forces declaration emit validation even
with `noEmit`, and TS 5.8 hits the serialization length limit (TS7056)
on several components with complex `defineComponent` return types.
Declaration files are generated separately by vite-plugin-dts during
the vite build, so the type-check does not need `composite`.
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Replace using constructor injection with using the inject function. Constructor injections is discouraged by angular's lint rules starting with Angular 20.
lucas-koehler
force-pushed
the
lk/angular-update-22rc
branch
from
d248518 to
2515049
Compare
|
coverage: 82.946% (-0.01%) from 82.959% — lk/angular-update-22rc into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further changes:
inject()instead of constructor injection: constructor injections are discouraged by angular's lint rules starting with Angular 20I tested this locally with the seed building against 22 RC.0 and it worked fine :) I needed one small code change resulting from an unrelated update of the Angular enum renderer. In addition, constructor injection of custom renderers needed to be replaced as described in the migration doc.
The examples app worked fine for me, too which builds against Angular 20 now, too