fix(popover): avoid SwiftUI ProgressView constraint assertion#19
Open
jeanfw wants to merge 1 commit into
Open
Conversation
Combining .scaleEffect(0.7) and .frame(width:20, height:20) on the
refresh button's circular ProgressView triggers a SwiftUI runtime
assertion on macOS ("maximum length doesn't satisfy min <= max" with
identical operands), caused by AppKit's NSProgressIndicator returning
an intrinsic size that fails strict floating-point comparison against
the framed bounds. Switching to .controlSize(.small) gives the same
visual reduction without conflicting size constraints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The refresh button in the usage popover composes
ProgressView().scaleEffect(0.7).frame(width: 20, height: 20). On macOS this triggers a SwiftUI runtime assertion when the button enters the refreshing state:The min and max are identical values (≈
225/7), but SwiftUI's strict floating-point comparison still rejects them. The cause: AppKit'sNSProgressIndicatorreturns an intrinsic content size that's a non-terminating decimal, and feeding it back throughscaleEffect+frameproduces values that fail bitwise equality.The fix
Replace the
scaleEffect(0.7) + frame(20, 20)combo withcontrolSize(.small). This is the macOS-native way to ask for a smaller spinner and skips the conflicting size constraints — same visual reduction, no runtime assertion, fewer modifiers.Test plan
arrow.clockwiseicon when the popover is idle.🤖 Generated with Claude Code