refactor(worker): pass IsolatePool as injected dependency#1946
Merged
Conversation
Contributor
Author
|
This is another spin-off from #1900 |
Theodus
approved these changes
Mar 10, 2026
Member
Theodus
left a comment
Theodus
left a comment
There was a problem hiding this comment.
LGTM, just seems like there were some misplaced comments during the refactor.
LNSD
force-pushed
the
refactor-worker-pass-isolate-pool-dep
branch
from
28a4e36 to
8280f43
Compare
shiyasmohd
approved these changes
Mar 10, 2026
Contributor
shiyasmohd
left a comment
shiyasmohd
left a comment
There was a problem hiding this comment.
LGTM. Added suggestions in comments.
Align IsolatePool lifecycle with the established dependency injection pattern where shared resources are created at binary entry points and propagated through service contexts. - Remove `IsolatePool::new()` from `exec_env::create()` and accept it as a parameter - Create `IsolatePool` at `ampd` command entry points (server, worker, solo) - Thread pool through `server::service`, `flight::Service`, and `WorkerJobCtx` - Add `isolate_pool` field to derived dataset `Context` for job execution Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
LNSD
force-pushed
the
refactor-worker-pass-isolate-pool-dep
branch
from
8280f43 to
b35260b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align
IsolatePoollifecycle with the established dependency injection pattern where shared resources are created at binary entry points and propagated through service contexts.IsolatePool::new()fromexec_env::create()and accept it as a parameterIsolatePoolatampdcommand entry points (server, worker, solo)server::service,flight::Service, andWorkerJobCtxisolate_poolfield to derived datasetContextfor job execution