Skip to content

fix(core): avoid redudant work when chain did not move #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leoyvens merged 1 commit into from
Mar 12, 2026
Merged

fix(core): avoid redudant work when chain did not move #1964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions crates/core/worker-datasets-raw/src/job_impl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,7 @@ pub async fn execute(
//
// We wrap the loop in a block to handle errors and emit failure events.
let materialize_result: Result<(), Error> = async {
let mut prev_latest_block: Option<BlockNum> = None;
loop {
let Some(latest_block) = client
.latest_block(finalized_blocks_only)
Expand All @@ -299,6 +300,13 @@ pub async fn execute(
timer.tick().await;
continue;
};

// Skip recomputing missing ranges if latest_block hasn't changed.
if Some(latest_block) == prev_latest_block {
timer.tick().await;
continue;
}

if latest_block < start {
// Start not yet reached, wait for more data
timer.tick().await;
Expand Down Expand Up @@ -337,6 +345,9 @@ pub async fn execute(

// If there are no ranges then there is no more work to do, check materialize end condition.
if missing_dataset_ranges.is_empty() {
// Work for this block is complete
prev_latest_block = Some(latest_block);

// If we've reached the configured end block, stop completely and return.
if let Some(end) = end
&& end <= latest_block
Expand Down
Loading