Skip to content

fix(amp-worker-core): exclude hot files from compaction groups #1969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Theodus wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(amp-worker-core): exclude hot files from compaction groups #1969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/core/worker-core/src/compaction/algorithm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,10 +207,10 @@ impl CompactionAlgorithm {
/// - When a group is started, if the candidate can be added to it.
///
/// The current algorithm is:
/// - If the file is `Hot`, it cannot start a new group.
/// - If a group has been started, it will accept files up to the target size, regardless of file state.
/// - If the file is `Hot`, it is excluded from compaction entirely (cannot start or join a group).
/// - If a group has been started, it will accept non-hot files up to the target size.
pub fn predicate(&self, group: &CompactionGroup, candidate: &CompactionFile) -> bool {
if group.is_empty() && self.file_state(&candidate.size) == FileState::Hot {
if self.file_state(&candidate.size) == FileState::Hot {
return false;
}

Expand Down
Loading