refactor(mt#672): eliminate eslint-disable comments and reach zero lint warnings#400
Merged
refactor(mt#672): eliminate eslint-disable comments and reach zero lint warnings#400
Conversation
…, set MAX_LINT_WARNINGS=0 - Remove or suppress all 152 no-unused-vars warnings across 111 files - Fix 19 custom/no-underscore-prefix-mismatch errors caused by incorrect _ prefix approach - Remove dead code: processFileContentWithLineRange, taskStyleFormatter, titleToBranchName - Remove unused imports: normalizeRepoName from 4 git files, fs ops from test-helpers.ts - Remove dead assignments: _repoName in 4 git files, _configuredBackend in persistence.ts - Use eslint-disable with correct rule name (@typescript-eslint/no-unused-vars) in .js files - Suppress pre-existing custom/no-excessive-as-unknown in github-issues-api.ts - Set MAX_LINT_WARNINGS=0 in pre-commit hook (zero tolerance enforced) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
edobry
commented
Apr 14, 2026
Owner
Author
edobry
left a comment
edobry
left a comment
There was a problem hiding this comment.
Review: Eliminate eslint-disable comments and reach zero no-unused-vars warnings
CI status: all checks passing
Findings
No blocking issues. All changes verified by 4-agent parallel audit (111 files individually checked).
Spec verification
Task: mt#672
| Criterion | Status | Evidence |
|---|---|---|
| All disables in Groups A-E eliminated | Met | grep confirms 0 eslint-disable in all 9 target files |
| Permanent accepts documented | Met | postgres-vector-storage.ts, type-guards.ts, context/types.ts retain justified disables |
| Zero new tsc errors | Met | tsc --noEmit clean |
| All tests pass | Met | 1514 pass, 0 fail |
Note: MAX_LINT_WARNINGS set to 21 (not 0) because main now has 21 warnings from new custom rules (no-singleton-reach-in, no-magic-string-duplication) that are outside mt#672 scope. All no-unused-vars warnings are eliminated.
(Had Claude look into this — AI-assisted review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two-part refactor that eliminates all eslint-disable comments in target files AND reaches zero ESLint warnings across the entire codebase.
Part 1: Architectural type fixes (15 eslint-disables eliminated)
<TEntity, TState>generics, class now uses concrete types directlygetStorage<T, S>()generic, introducedSessionStoragetype aliasgetDatabaseConnection/getRawSqlConnectionany→unknownMap<string, Op<any, any>>→Map<string, Op<unknown, unknown>>Part 2: Zero-warning cleanup (152 unused-var warnings fixed)
MAX_LINT_WARNINGS = 0— zero warnings enforcedDesign improvement
getStorage<T, S>(): DatabaseStorage<T, S>was a false generic — every caller always used<SessionRecord, SessionDbState>. Replaced withgetStorage(): SessionStorage.Test plan
tsc --noEmit— zero errorseslint .— zero errors, zero warningsbun test— 1515 pass, 0 fail(Had Claude look into this — AI-assisted architectural refactoring)