Skip to content

Conversation

@nsprenkle
Copy link
Member

This function was renamed from _make_mako_template_dirs to make_mako_template_dirs.

This also inherits the addition of a local theming directory used for edx development.


I've completed each of the following or determined they are not applicable:

  • Made a plan to communicate any major developer interface changes (or N/A)

Copilot AI review requested due to automatic review settings September 24, 2025 17:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the naming of a function from _make_mako_template_dirs to make_mako_template_dirs across multiple files and documentation. The change removes the underscore prefix, indicating the function is no longer considered private.

  • Updates function name references in comments and shell scripts
  • Adds a new local theming directory path for edx development
  • Ensures consistency across documentation and configuration files

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
py_configuration_files/lms.py Updates commented function references and adds new theme directory path
provision-set-edx-theme.sh Updates sed commands to match the new function name
docs/devstack_faq.rst Updates documentation examples with correct function name

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@timmc-edx timmc-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though the bot might be right about the comment change. (It does appear to be a properly documented public function now.)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 24, 2025 18:21
@nsprenkle
Copy link
Member Author

Looks good, though the bot might be right about the comment change. (It does appear to be a properly documented public function now.)

Yup, it's a good catch. Have updated.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@nsprenkle nsprenkle merged commit 32ebaf4 into master Sep 24, 2025
19 checks passed
@nsprenkle nsprenkle deleted the nsprenkle/fix_mako_function_naming branch September 24, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants