Fix error collision#61
Conversation
There are four types of errors: - Unknown seed, - CRC mismatch, - Invalid types, - Execution time < 10s. All of these errors are handled by the 'total_errors' variable. However, handling of the 'unknown seed' error differs from other types: it sets 'total_errors' to -1, while other types of errors increment this variable. This behavior leads to situations where one error overrides another. For example, if you compile the program incorrectly and get an unknown seed, and then run the program for less than 10 seconds, you will get total_errors = 0 (because one error sets it to -1, while another increments it to 0). See eembc#4. As a result, you'll receive "Correct operation validated" when you shouldn't.
| if (total_errors > 0) | ||
| ee_printf("Errors detected\n"); | ||
| if (total_errors < 0) | ||
| if (known_id < 0) |
There was a problem hiding this comment.
The known_id variable is initialized by -1 and then it reassigned to positive value in switch(seedcrc) block of code. Thus, known_id < 0 is basically the same indicator as current check total_errors < 0, but without error type collision in total_errors variable.
There was a problem hiding this comment.
Thanks for the details. I will look into this in a couple of weeks time.
Joseph
There was a problem hiding this comment.
@joseph-yiu, hello!
I see a lot of work is going in nearby issues/PRs. Is there any chance you missed this one?
There was a problem hiding this comment.
Hi @HepoH3 ,
It is still on my list of to-do task.
Sorry for the delay.
Joseph
There was a problem hiding this comment.
Hi @HepoH3 ,
I have reviewed the pull request and am happy with the changes. I have merged it into the development branch dev_2026q3, and will close it when we officially release the new version.
regards,
Joseph
2 participants
There are four types of errors:
All of these errors are handled by the 'total_errors' variable. However, handling of the 'unknown seed' error differs from other types: it sets 'total_errors' to -1, while other types of errors increment this variable.
This behavior leads to situations where one error overrides another. For example, if you compile the program incorrectly and get an unknown seed, and then run the program for less than 10 seconds, you will get total_errors = 0 (because one error sets it to -1, while another increments it to 0). See #4.
As a result, you'll receive "Correct operation validated" when you shouldn't.