build: re-enable ThinLTO on macOS#51669
Draft
ckerr wants to merge 1 commit into
Draft
Conversation
ckerr
force-pushed
the
fix/reland-thin-lto-mac
branch
from
3bc4823 to
9a99741
Compare
ckerr
added
target/42-x-y
Member
|
Could you trigger a release build from this branch before merging for verification, thanks! |
Member
Author
|
Re-enabling ThinLTO on macOS is surfacing a new issue for header-only classes with vtables. I need to fix this & then I'll mark this as ready for review again. |
Re-enable ThinLTO on macOS. Add a patch to the bundled Node.js source that anchors weak vtables and N-API entry points so they survive clang's -fwhole-program-vtables under ThinLTO. See the patch's commit message for details.
ckerr
force-pushed
the
fix/reland-thin-lto-mac
branch
from
9a99741 to
e66dbe9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #44632.
Re-enable ThinLTO on macOS. Add a new patch to ensure N-API entry points aren't stripped by ThinLTO by copying the
__attribute__((used))approach from nodejs/node#49037 .All reviews welcomed; CC @VerteDinde as a stakeholder for opening 44632
Checklist
npm testpassesRelease Notes
Notes: Enabled ThinLTO on macOS builds.