Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3947
The dev Docker environment was broken due to several issues that prevented the container from building and serving the site.
Changes Summary
node_18.xapt repository (EOL since April 2025, no longer distributing packages) with a multi-stage build using the officialnode:18imagenode,npm, andnpxare now copied directly from the official image;npm/npxare created as symlinks intonode_modules/npm/bin/to preserve correct module resolutionapt-getlayer, removing the now-unnecessary NodeSource setup stepscomposer up→composer install(composer up is not a valid command)set -eso the script exits immediately on any error rather than silently continuing through failuresversionfromdev/docker-compose.ymlto get rid of a warningsubmodulefrom normal builds as image cache makes this not requiredTesting
Run
cd ./dev && docker-compose upand wait for the build to finish, then load localhost:8000This pull request is ready for review.