Skip to content

Fix docker image builds#3997

Merged
lewisgoddard merged 1 commit intomasterfrom
fix-3947-docker
Feb 28, 2026
Merged

Fix docker image builds#3997
lewisgoddard merged 1 commit intomasterfrom
fix-3947-docker

Conversation

@lewisgoddard
Copy link
Member

@lewisgoddard lewisgoddard commented Feb 28, 2026

Fixes #3947

The dev Docker environment was broken due to several issues that prevented the container from building and serving the site.

Changes Summary

  • Replaced the broken NodeSource node_18.x apt repository (EOL since April 2025, no longer distributing packages) with a multi-stage build using the official node:18 image
  • node, npm, and npx are now copied directly from the official image; npm/npx are created as symlinks into node_modules/npm/bin/ to preserve correct module resolution
  • Consolidated into a single apt-get layer, removing the now-unnecessary NodeSource setup steps
  • Fixed composer upcomposer install (composer up is not a valid command)
  • Added set -e so the script exits immediately on any error rather than silently continuing through failures
  • Removed version from dev/docker-compose.yml to get rid of a warning
  • Removed submodule from normal builds as image cache makes this not required

Testing

Run cd ./dev && docker-compose up and wait for the build to finish, then load localhost:8000

This pull request is ready for review.

@lewisgoddard lewisgoddard requested a review from a team February 28, 2026 01:15
@lewisgoddard lewisgoddard enabled auto-merge (squash) February 28, 2026 01:16
@lewisgoddard lewisgoddard added this to the Total Automation milestone Feb 28, 2026
@lewisgoddard lewisgoddard changed the title Fix docker image Fix docker image builds Feb 28, 2026
Copy link
Member

@tintou tintou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@lewisgoddard lewisgoddard merged commit dfb1fb6 into master Feb 28, 2026
5 checks passed
@lewisgoddard lewisgoddard deleted the fix-3947-docker branch February 28, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

External Assets (images, svg files etc) do not load correctly when running the website in a docker container

2 participants