Skip to content

Fix mysql structure load failures #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greg-rychlewski merged 1 commit into from
Apr 7, 2026
+9 −3
Merged

Fix mysql structure load failures #727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions lib/ecto/adapters/myxql.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,10 +588,13 @@ defmodule Ecto.Adapters.MyXQL do
args: args
]

# Trap exits in case mysql dies in the middle of execution so that we can surface the error
old_trap_exit = Process.flag(:trap_exit, true)
port = Port.open({:spawn_executable, abs_cmd}, port_opts)
send(port, {self(), {:command, contents}})
send(port, {self(), {:command, ";SELECT '__ECTO_EOF__';\n"}})
collect_output(port, "")
Port.command(port, [contents, ";SELECT '__ECTO_EOF__';\n"])
result = collect_output(port, "")
Process.flag(:trap_exit, old_trap_exit)
result
end

defp args_env(opts, opt_args) do
Expand Down Expand Up @@ -651,6 +654,9 @@ defmodule Ecto.Adapters.MyXQL do
collect_output(port, acc)
end

{:EXIT, ^port, _reason} ->
{acc, 1}

{^port, {:exit_status, status}} ->
{acc, status}
end
Expand Down
Loading