Propagate download errors instead of falling back to a misleading file-not-found#97
Merged
Merged
Conversation
gmile
force-pushed
the
propagate-download-error
branch
from
6c3d0c3 to
c403d67
Compare
Member
|
Looks good to me! |
When a precompiled NIF download failed, the error from Artefact.download/2 was discarded and verify_and_decompress/2 then ran on the missing file, reporting a misleading :enoent. Capture the download result and only verify on success.
gmile
force-pushed
the
propagate-download-error
branch
from
c403d67 to
c7cc804
Compare
Contributor
Author
|
I force-pushed (by just changing the commit SHA), in an attempt to perform a re-run to fix what looks like flaky test failures. But looks like a GH actions run is pending approval. @josevalim I went ahead and marked this PR as "ready for review" |
Member
|
💚 💙 💜 💛 ❤️ I will fix the heisenbug locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently we were puzzled by an attempt to compile
lazy_htmllibrary during an otherwise boring CI run, which never happened before. Upon closer look, it seems like it might have been a network hiccup.This change improves the error message.
Artefact.download/2was discarded andverify_and_decompress/2then ran on the missing file, reporting a misleading:enoentinstead of the real reason.