Skip to content

Support Hackney 4.x#824

Draft
tomekowal wants to merge 1 commit intoelixir-tesla:masterfrom
tomekowal:support-hackney-2.x
Draft

Support Hackney 4.x#824
tomekowal wants to merge 1 commit intoelixir-tesla:masterfrom
tomekowal:support-hackney-2.x

Conversation

@tomekowal
Copy link
Copy Markdown
Contributor

@tomekowal tomekowal commented Jan 24, 2026 •
edited
Loading

This PR is a starting point on supporting hackney 2.x by tesla.
So far:

TBD:

  • if the adapter for Hackney 2.x will require extensive changes, it might be better to have a second module and decinde at runtime which one to load

TODO:

  • make sure all tests pass
  • squash to conventional commits after everything works

Note: the tests here are green because they still use old hackney. On new version

@tomekowal tomekowal mentioned this pull request Jan 24, 2026
Open
@yordis
Copy link
Copy Markdown
Member

yordis commented Jan 26, 2026

if the adapter for Hackney 2.x will require extensive changes, it might be better to have a second module and decinde at runtime which one to load

If you feel that is the right approach, I really do not mind. These type of configuration are barely the "every day" situation. So, feel free to create a HackneyV2 and we mark the module as experimental in the worse case.

Try to keep safety checks at compile-time as much as we can.

Make it work, then make it beautiful.

@tomekowal tomekowal changed the title Support Hackney 2.x Support Hackney 3.x Feb 15, 2026
@tomekowal tomekowal force-pushed the support-hackney-2.x branch from d97f067 to 5c37538 Compare March 18, 2026 07:05
@tomekowal @claude
Support hackney 3.x
b4e3ac3 
- Handle PID connection handles (hackney 2.x+ uses PIDs instead of refs)
- Add finish_send_body call for streaming requests
- Convert cacertfile to cacerts for hackney 3.x SSL compatibility
- Use hackney_conn.body/2 for reading response body in hackney 3.x
- Remove deprecated max_body test (hackney 3.x changed body reading API)
- Require hackney >= 3.2.1 (fixes recv_timeout with connection pooling)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@tomekowal tomekowal force-pushed the support-hackney-2.x branch from 5c37538 to b4e3ac3 Compare March 18, 2026 07:16
@yordis
Copy link
Copy Markdown
Member

yordis commented Apr 22, 2026

@tomekowal should I merge #498 and ideally, if possible, your upgrade would tackle it?

@tomekowal
Copy link
Copy Markdown
Contributor Author

tomekowal commented Apr 23, 2026

Yeah. I am totally fine rebasing on top of that work :)

@yordis
Copy link
Copy Markdown
Member

yordis commented Apr 23, 2026

Actually double guessing myself, I haven't use hackney enough to feel confident taking it 😭

@tomekowal
Copy link
Copy Markdown
Contributor Author

tomekowal commented Apr 23, 2026 •
edited
Loading

Ah. I see. Then I'll try to take a look and review streaming PR. I am at ElixirConf EU right now, so this weekend I am traveling and won't be able to tackle it. I'll try to find some time first weekend of May (but can't promise anything).

I think it makes sense to merge streaming first and then upgrade both :)

@tomekowal tomekowal changed the title Support Hackney 3.x Support Hackney 4.x Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomekowal @yordis