Add type Integer48 #128
Open
Add type Integer48 #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-hillmann
requested changes
Sep 23, 2022
Contributor
michael-hillmann
left a comment
michael-hillmann
left a comment
There was a problem hiding this comment.
Good work. Thank you for writing this type.
giuliobenetti
force-pushed
the
dev/add-integer48
branch
from
78ff13a to
37f9da2
Compare
Let's add integer48 type by using uint64_t as base data type. Note that Integer48 type can't use Direct Storage. Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
giuliobenetti
force-pushed
the
dev/add-integer48
branch
from
37f9da2 to
cb9228f
Compare
Contributor
|
can you change the target branch to 'develop', please? |
Author
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's add integer48 type by using uint64_t as base data type.
Signed-off-by: Giulio Benetti giulio.benetti@benettiengineering.com