Add no-computed-without-dependent-keys rule#346
Open
gmurphey wants to merge 1 commit intoember-cli:masterfrom
Open
Add no-computed-without-dependent-keys rule#346gmurphey wants to merge 1 commit intoember-cli:masterfrom
no-computed-without-dependent-keys rule#346gmurphey wants to merge 1 commit intoember-cli:masterfrom
Conversation
Turbo87
reviewed
Nov 28, 2018
| const ember = require('../utils/ember'); | ||
|
|
||
| //------------------------------------------------------------------------------ | ||
| // General rule - Don't introduce side-effects in computed properties |
Member
There was a problem hiding this comment.
the comment banner will need to be updated or removed
| message: 'A computed property needs dependent keys' | ||
| }] | ||
| }, | ||
| ], |
Member
There was a problem hiding this comment.
can you add tests for a few of the common computed property macros?
Contributor
Author
|
Also realized we'll need to ignore volatile computeds for this rule. |
gmurphey
force-pushed
the
no-computed-without-dependent-keys
branch
from
4823a98 to
99ae07b
Compare
Turbo87
changed the title
no-computed-without-dependent-keys rule
Member
|
I'd love to land this. @gmurphey - Have any cycles to address the feedback and rebase? |
Member
|
Thoughts on using |
rwjblue
reviewed
Jun 26, 2019
Member
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
Also need to add an invalid test for:
export default Ember.Component({
foo: computed({
get() {
return this.get('bar') * 2;
}
})
});
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todo: