[BUGFIX] plain method calling from templates (no explicit binding required -- follows JS semantics) - on still requires binding #21469
Open
NullVoxPopuli wants to merge 4 commits into
Open
Conversation
NullVoxPopuli
commented
Jun 12, 2026
| assert.equal(this.stashedFn(), 'arg1: foo, arg2: bar'); | ||
| } | ||
|
|
||
| '@test there is no `this` context within the callback'(assert) { |
Contributor
Author
There was a problem hiding this comment.
a change in behavior, but for the better -- I dare say: a bugfix
Contributor
📊 Size reportTarball size — dist/dev 0.1%↑
dist/prod 0.1%↑
smoke-tests/v2-app-template/dist 0.08%↑
smoke-tests/v2-app-hello-world-template/dist 0.2%↑
🤖 This report was automatically generated by wyvox/pkg-size |
NullVoxPopuli
changed the title
NullVoxPopuli
changed the title
NullVoxPopuli
commented
Jun 12, 2026
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-return -- @fixme | ||
| return (fn as AnyFn).call(context, ...args, ...invocationArgs); | ||
| return (fn as AnyFn).call(self, ...args, ...invocationArgs); |
Contributor
Author
There was a problem hiding this comment.
the actual fix is here
NullVoxPopuli
commented
Jun 12, 2026
| * The reference this one was created from via a property read (`parent.path`), | ||
| * if any. See {@linkcode parentRefFor}. | ||
| */ | ||
| public parent: Nullable<Reference> = null; |
Contributor
Author
There was a problem hiding this comment.
more reference linking 🙈
ef4
reviewed
Jun 16, 2026
Contributor
Author
|
from review times -- this PR needs to be re-worked to only solve |
NullVoxPopuli
force-pushed
the
nvp/fix-this-binding-for-real
branch
from
f25e012 to
889278b
Compare
NullVoxPopuli
changed the title
on still requires binding
NullVoxPopuli
force-pushed
the
nvp/fix-this-binding-for-real
branch
from
889278b to
4b573d6
Compare
…ms of the language
NullVoxPopuli
force-pushed
the
nvp/fix-this-binding-for-real
branch
from
4b573d6 to
9c29b51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supersedes
this PR enables/unblocks the change in recommendation RFC:
@actiondecorator rfcs#1045Main test cases I care about:
Things we didn't fix (because these are problems with JavaScript)
on(addEventListener)REPL PR: NullVoxPopuli/limber#2170
Deployed: https://test-ember-source-nvp-fix-th.limber-glimdown.pages.dev/
Demo: https://test-ember-source-nvp-fix-th.limber-glimdown.pages.dev/edit?c=JYWwDg9gTgLgBAYQuCA7Apq%2BAzKy4DkAAgOYA2oI6UA9AMbKQZYEDcAUKJLHAN5wwoAQzoBrdABM4AXzi58xcpWo1BI0cFQk27dugAe3eBPTYhAVzLw6ZIQGc7cABLoyZCAHVoZKQZiYJRyQUZnhedjg4IjUxSTgGcyw4AF44AAYOCLgaGjgodABHc2B8qRgIOAAjdDghKDwAdzg7GGA3LM06fKok1IAKAEoUgD4%2BLMiYAAtgOwA6BKSAalSARg5I2V1IiQhzSrJJQbHIyPyYcyhUAWm5hfgAKjgAJnWZLbgAHn9wW39h8c%2BYGGAE1dnBJkIAG41GzAWJlSY1SrmGDlK68XhTGbzXZYaSyVpUOYfGhAgEfIFCVBSHZ7A4SABcfExN1mtP2knxJLJ5ORqLQAgAnmB0MkAER8tFi5kCsWwsTSrFzTrdTAwfHDBAUMQkyVof6REnfMC-dD-aTsIA&format=gjs