Skip to content

[WasmFS] Use const uint8_t* in JS API impl. NFC #24706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kleisauke merged 4 commits into from
Apr 6, 2026
+2 −2
Merged

[WasmFS] Use const uint8_t* in JS API impl. NFC #24706

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce22964
[WasmFS] Use `const char*` in JS API impl. NFC
kleisauke Jun 9, 2023
dc5255e
Merge branch 'main' into wasmfs-js-api-constness
kleisauke Jul 15, 2025
7398284
Merge branch 'main' into wasmfs-js-api-constness
kleisauke Apr 4, 2026
251c091
Avoid a cast
kleisauke Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions system/lib/wasmfs/js_api.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ int _wasmfs_read_file(const char* path, uint8_t** out_buf, off_t* out_size) {

// Writes to a file, possibly creating it, and returns the number of bytes
// written successfully. If the file already exists, appends to it.
int _wasmfs_write_file(const char* pathname, char* data, size_t data_size) {
int _wasmfs_write_file(const char* pathname, const uint8_t* data, size_t data_size) {
auto parsedParent = path::parseParent(pathname);
if (parsedParent.getError()) {
return 0;
Expand Down Expand Up @@ -100,7 +100,7 @@ int _wasmfs_write_file(const char* pathname, char* data, size_t data_size) {
}

auto offset = lockedFile.getSize();
auto result = lockedFile.write((uint8_t*)data, data_size, offset);
auto result = lockedFile.write(data, data_size, offset);
if (result != __WASI_ERRNO_SUCCESS) {
return 0;
}
Expand Down
Loading