poll: Add pollAsync API to the stream backend #26196
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the stream backend's poll API and explicitly splits it into synchronous and asynchronous APIs. The poll API synchronously checks the events. The backend can also implement the pollAsync API which can wait for the event asynchronously and notify the caller using the callback when the event occurs. Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
sbc100
reviewed
Feb 2, 2026
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
looks like a good direction.
| } | ||
| } | ||
|
|
||
| #if PTHREADS |
Collaborator
There was a problem hiding this comment.
Hmm.. I do you know why this isn't #if PTHREADS || ASYNCIFY like it is in libsyscall.sj.. I'm suprised that the tests still pass despite this.
| pollAsync(stream, notifyCallback) { | ||
| var res = this.poll(stream, 0); | ||
| if (res != 0) return res; | ||
| #if PTHREADS |
Collaborator
There was a problem hiding this comment.
I think the whole of pollAsync should probably be wrapped in #if PTHREADS || ASYNCIFY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in #26192
This PR only contains the refactoring of the APIs following the suggestion in #26192. I think we need additional patches if we want to fully restore the legacy behavior (i.e. ignoring the timeout argument) for the sockfs.
This commit refactors the stream backend's poll API and explicitly splits it into synchronous and asynchronous APIs. The poll API synchronously checks the events. The backend can also implement the pollAsync API which can wait for the event asynchronously and notify the caller using the callback when the event occurs.